Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-name dashboard references to Cypress Cloud #24699

Merged
merged 9 commits into from Nov 17, 2022

Conversation

astone123
Copy link
Contributor

User facing changelog

n/a

Additional details

We are now referring to dashboard as Cypress Cloud. This PR updates all of the wording around the dashboard to use "Cypress Cloud" instead. I also updated some internal variable names to say "cloud" rather than "dashboard".

Steps to test

The most important thing to test is that all Cypress Cloud actions still work with these changes. Verify the following:

  • You can still log into Cypress Cloud
  • The "connect project" modal flow still works
  • Runs tab still links to the correct runs
  • Latest runs, flaky badges, and average duration still appear on the specs list
  • Other cloud integration things that I'm forgetting

Also verify that all visible copy refers to Cypress Cloud (not dashboard) and follows the brand standards

PR Tasks

@astone123 astone123 requested review from davidr-cy and a team November 15, 2022 23:21
@astone123 astone123 self-assigned this Nov 15, 2022
@cypress-bot
Copy link

cypress-bot bot commented Nov 15, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Nov 15, 2022

CLA assistant check
All committers have signed the CLA.

@cypress
Copy link

cypress bot commented Nov 15, 2022

Copy link
Member

@lmiller1990 lmiller1990 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good - I left one nit, but not really a big deal.

If you did just want to rename without re-running CI, you can commit with a commit message containing skip ci and it won't run. https://circleci.com/docs/skip-build/#skipping-a-build

packages/app/src/runs/RunsError.spec.tsx Outdated Show resolved Hide resolved
@astone123 astone123 requested a review from a team November 16, 2022 22:06
Copy link
Contributor

@amehta265 amehta265 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything looks good locally and percy looks good to!

@astone123 astone123 merged commit e3435b6 into develop Nov 17, 2022
82 of 83 checks passed
@astone123 astone123 deleted the astone123/cloud-rebrand branch November 17, 2022 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rebrand dashboard to cloud
6 participants