Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: A docblock pointing to a non-existent online tool #24771

Merged

Conversation

DCzajkowski
Copy link
Contributor

@DCzajkowski DCzajkowski commented Nov 22, 2022

Fixed a URL in a docblock pointing to a non-existent tool. It is problematic, as the domain is for sale now and could point to some NSFW content any time.

We could also say "We suggest using an online glob-testing tool to verify what files would match."

Disclaimer: I have no association with the newly-linked online tool.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link

cypress-bot bot commented Nov 22, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Nov 22, 2022

CLA assistant check
All committers have signed the CLA.

@DCzajkowski DCzajkowski changed the title Changed non-existent globtester.com with other online tool for glob matching fix: A docblock pointing to a non-existent online tool Nov 22, 2022
@DCzajkowski DCzajkowski force-pushed the fix/globtester-does-not-exist-anymore branch from 1b4ff47 to d72ea19 Compare November 22, 2022 13:58
cli/types/cypress.d.ts Outdated Show resolved Hide resolved
@nagash77 nagash77 merged commit ec01774 into cypress-io:develop Nov 22, 2022
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Closed
Development

Successfully merging this pull request may close these issues.

None yet

3 participants