Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added experimentalOriginDependencies to gate dependencies support within cy.origin #24931

Merged
merged 2 commits into from
Dec 1, 2022

Conversation

mschile
Copy link
Contributor

@mschile mschile commented Dec 1, 2022

  • Closes n/a

User facing changelog

  • Added new experimentalOriginDependencies flag to enable support for request/import within cy.origin. Previously this feature was enabled with the experimentalSessionAndOrigin flag.

Additional details

The webpack loader cross-origin-callback-loader used to support request/import within cy.origin can result in OOM errors when parsing large files that may import a large dependency graph even if those files don't use cy.origin.

Screen Shot 2022-12-01 at 2 05 02 PM

Steps to test

  • Run against the cognito.spec.js within the cypress-realworld-app project.

How has the user experience changed?

  • The cross-origin-callback-loader is only used if the experimentalOriginDependencies flag is set. The error message has been updated to inform the user to enable the flag.

Screen Shot 2022-12-01 at 1 57 37 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [Not Yet] Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 1, 2022

Thanks for taking the time to open a PR!

@mjhenkes mjhenkes self-requested a review December 1, 2022 21:13
@AtofStryker AtofStryker self-requested a review December 1, 2022 21:16
@cypress
Copy link

cypress bot commented Dec 1, 2022



Test summary

21656 0 1716 0Flakiness 2


Run details

Project cypress
Status Passed
Commit 3d5bded
Started Dec 1, 2022 9:18 PM
Ended Dec 1, 2022 9:35 PM
Duration 17:23 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

specs_list_latest_runs.cy.ts Flakiness
1 App/Cloud Integration - Latest runs and Average duration > when no runs are recorded > shows placeholders for all visible specs
cypress-origin-communicator.cy.ts Flakiness
1 Cypress In Cypress Origin Communicator > cy.origin passivity with app interactions > passes upon test reload mid test execution

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@mjhenkes mjhenkes merged commit 98efdf4 into release/12.0.0 Dec 1, 2022
@mjhenkes mjhenkes deleted the matth/fix/experimentalOriginDependencies branch December 1, 2022 21:40
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 6, 2022

Released in 12.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v12.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants