feat(12): change testIsolation values from on/off to true/false #24935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
mjhenkes
approved these changes
Dec 2, 2022
AtofStryker
approved these changes
Dec 2, 2022
chrisbreiding
requested changes
Dec 2, 2022
| validation: (key: string, value: any, opts: ValidationOptions) => { | ||
| const { testingType } = opts | ||
|
|
||
| let configOpts = ['on', 'off'] | ||
| let configOpts = [true, false] |
There was a problem hiding this comment.
I feel like this should use validate.isBoolean, but for component testing, would need add either validate.isTrue or validate.isExactValue.
There was a problem hiding this comment.
Looking at this, validate.isBoolean accepts a null value, and we only want true & false. Not sure it's the best option for this?
Co-authored-by: Chris Breiding <chrisbreiding@users.noreply.github.com>
chrisbreiding
approved these changes
Dec 2, 2022
skjnldsv
added a commit
to nextcloud-libraries/nextcloud-cypress
that referenced
this pull request
Dec 6, 2022
…igin` cypress-io/cypress#24935 Signed-off-by: John Molakvoæ <skjnldsv@users.noreply.github.com>
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After, sync with @brian-mann we decided
trueandfalsewas more appropriate values fortestIsolationinstead ofonandoff.User facing changelog
Changes the testIsolation configuration values from
onorofftotrueorfalse.cypress-documentation?type definitions?