Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: updates to ci params sent to cloud for jenkins #25036

Merged
merged 7 commits into from
Dec 29, 2022

Conversation

davidr-cy
Copy link
Contributor

@davidr-cy davidr-cy commented Dec 7, 2022

  • Closes Cloud Issue

User facing changelog

Users running pull requests in Jenkins weren't getting links back to the pull request from Cypress Cloud. This pull request updates the Jenkins mapping along with providing a workaround given other mappings are incorrect or unmapped CI providers are used.

CYPRESS_PULL_REQUEST_ID
CYPRESS_PULL_REQUEST_URL
CYPRESS_CI_BUILD_URL

Additional details

CI mappings for jenkins are out of date and haven't been updated

How has the user experience changed?

  • Users will be able to link back to pull requests when running builds via jenkins.
  • Users will be able to provide their own environment variables to link back to pull requests.

PR Tasks

  • Have tests been added/updated?
  • Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 7, 2022

Thanks for taking the time to open a PR!

@CLAassistant
Copy link

CLAassistant commented Dec 7, 2022

CLA assistant check
All committers have signed the CLA.

@davidr-cy davidr-cy force-pushed the davidr/feature/update-cloud-ci-params-jenkins branch from 57eead2 to 12b035b Compare December 7, 2022 19:44
@davidr-cy davidr-cy self-assigned this Dec 7, 2022
@davidr-cy davidr-cy marked this pull request as ready for review December 7, 2022 22:14
@cypress
Copy link

cypress bot commented Dec 7, 2022



Test summary

26394 0 1179 0Flakiness 30


Run details

Project cypress
Status Passed
Commit e6094b5
Started Dec 28, 2022 9:54 PM
Ended Dec 28, 2022 10:12 PM
Duration 18:10 💡
OS Linux Debian -
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

commands/net_stubbing.cy.ts Flakiness
1 network stubbing > intercepting request > can delay and throttle a StaticResponse
2 network stubbing > intercepting request > can delay and throttle a StaticResponse
3 ... > with `times` > only uses each handler N times
4 network stubbing > intercepting request > can delay and throttle a StaticResponse
e2e/origin/cookie_behavior.cy.ts Flakiness
1 ... > same site / cross origin > XMLHttpRequest > sets cookie on same-site request if withCredentials is true, and attaches to same-site request if withCredentials is true
This comment includes only the first 5 flaky tests. See all 30 flaky tests in the Cypress Dashboard.

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@emilyrohrbough emilyrohrbough added Cypress Cloud Feature request or issue in Cypress Cloud, not App CI: jenkins labels Dec 27, 2022
@emilyrohrbough emilyrohrbough changed the title feat: updates to ci params sent to cloud for jenkins fix: updates to ci params sent to cloud for jenkins Dec 27, 2022
packages/server/lib/util/ci_provider.js Outdated Show resolved Hide resolved
@davidr-cy davidr-cy merged commit 285e2b3 into develop Dec 29, 2022
@davidr-cy davidr-cy deleted the davidr/feature/update-cloud-ci-params-jenkins branch December 29, 2022 14:58
@jennifer-shehane jennifer-shehane added CI General issues involving running in a CI provider and removed CI: jenkins labels Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI General issues involving running in a CI provider Cypress Cloud Feature request or issue in Cypress Cloud, not App
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants