Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: bump rollup & some vite deps #25140

merged 6 commits into from Dec 19, 2022

chore: bump rollup & some vite deps #25140

merged 6 commits into from Dec 19, 2022


Copy link

@lmiller1990 lmiller1990 commented Dec 14, 2022

User facing changelog


Additional details

Update some deps. For some reason I could not do yarn cypress:open --component in packages/frontend-shared - I'd get an error:


This was introduced by #25101. Bumping some related deps fixed it.

This problem was not manifesting in some other projects I tested. I do not think it is impacting users, just developers on the Cypress monorepo.

Steps to test

  • Pull down
  • Go in packages/frontend-shared
  • Open mode
  • I used
  • Usually workflow should work, no errors etc.

How has the user experience changed?

Works as expected

PR Tasks

  • [ na] Have tests been added/updated?
  • [ na] Has the original issue (or this PR, if no issue exists) been tagged with a release in ZenHub? (user-facing changes only)
  • [na ] Has a PR for user-facing changes been opened in cypress-documentation?
  • [ na] Have API changes been updated in the type definitions?

Copy link

cypress-bot bot commented Dec 14, 2022

Thanks for taking the time to open a PR!

@lmiller1990 lmiller1990 marked this pull request as ready for review December 19, 2022 06:14
@lmiller1990 lmiller1990 requested a review from a team December 19, 2022 06:33
Copy link
Member Author

The latest CI build is green, I don't know why GH hasn't updated the checks:

@rockindahizzy rockindahizzy requested a review from a team December 19, 2022 16:16
@astone123 astone123 merged commit 0e14b9e into develop Dec 19, 2022
72 of 75 checks passed
@astone123 astone123 deleted the lmiller/bump-rollup branch December 19, 2022 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants