fix: prerequest correlation for various retried and cached requests - #27771
Merged
ryanthemanuel merged 3 commits intoSep 11, 2023
Merged
Conversation
5 flaky tests on run #50914 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| ... > with `times` > only uses each handler N times |
Output
|
|
commands/waiting.cy.js • 1 flaky test • 5x-driver-webkit
| Test | Artifacts | |
|---|---|---|
| ... > errors > throws waiting for the 3rd response |
Output
|
|
cypress/cypress.cy.js • 3 flaky tests • 5x-driver-webkit
| Test | Artifacts | |
|---|---|---|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
| ... > correctly returns currentRetry |
Output
|
|
Review all test suite changes for PR #27771 ↗︎
chrisbreiding
approved these changes
Sep 8, 2023
AtofStryker
approved these changes
Sep 10, 2023
ryanthemanuel
deleted the
ryanm/fix/various-fixes-for-prerequest-correlation
branch
September 11, 2023 02:41
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
Fix prerequest correlation and response body capture for various retried and cached requests.
Steps to test
These scenarios are somewhat hard to reproduce, but I was able to stumble upon them through running through the suite of tests in the cypress dashboard.
How has the user experience changed?
Intercepts will now work more consistently.
PR Tasks
cypress-documentation?type definitions?