fix: fixing issue with blurring shadow dom elements - #29125
Merged
Conversation
Passing run #54565 ↗︎
Details:
Review all test suite changes for PR #29125 ↗︎ |
|||||||||||||||
AtofStryker
self-requested a review
March 13, 2024 14:58
AtofStryker
approved these changes
Mar 13, 2024
ryanthemanuel
approved these changes
Mar 19, 2024
Contributor
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Additional details
When retrieving the currently focused/active element, we are not taking into consideration the shadow dom. Thus, when we check to see if the element is currently focused and can be blurred, it fails since we do not think the shadow dom element is focused.
Steps to test
Focus an element in the shadow dom and then call
bluron it.How has the user experience changed?
Before:
After:
PR Tasks
cypress-documentation?type definitions?