Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency commander to version 2.19.0 🌟 #3366

Merged
merged 3 commits into from Feb 7, 2019

Conversation

2 participants
@renovate
Copy link
Contributor

renovate bot commented Feb 7, 2019

This PR contains the following updates:

Package Type Update Change References
commander dependencies minor 2.11.0 -> 2.19.0 source

Release Notes

tj/commander.js

v2.19.0

Compare Source

==================

  • Removed newline after Options and Commands headers (#​864)
  • Bugfix - Error output (#​862)
  • Fix to change default value to string (#​856)

v2.18.0

Compare Source

==================

v2.17.1

Compare Source

==================

v2.17.0

Compare Source

==================

v2.16.0

Compare Source

==================

v2.15.1

Compare Source

fix #​777
Released with npm@5.6.0

v2.15.0

Compare Source

==================

  • Update downloads badge to point to graph of downloads over time instead of duplicating link to npm
  • Arguments description

v2.14.1

Compare Source

==================

  • Fix typing of help function

v2.14.0

Compare Source

==================

  • only register the option:version event once
  • Fixes issue #​727: Passing empty string for option on command is set to undefined
  • enable eqeqeq rule
  • resolves #​754 add linter configuration to project
  • resolves #​560 respect custom name for version option
  • document how to override the version flag
  • document using options per command

v2.13.0

Compare Source

==================

  • Do not print default for --no-
  • remove trailing spaces in command help
  • Update CI's Node.js to LTS and latest version
  • typedefs: Command and Option types added to commander namespace

v2.12.2

Compare Source

==================

  • fix: typings are not shipped

v2.12.1

Compare Source

==================

v2.12.0

Compare Source

==================

  • add attributeName() method to Option objects
  • Documentation updated for options with --no prefix
  • typings: outputHelp takes a string as the first parameter
  • typings: use overloads
  • feat(typings): update to match js api
  • Print default value in option help
  • Fix translation error
  • Fail when using same command and alias (#​491)
  • feat(typings): add help callback
  • fix bug when description is add after command with options (#​662)
  • Format js code
  • Rename History.md to CHANGELOG.md (#​668)
  • feat(typings): add typings to support TypeScript (#​646)
  • use current node

Renovate configuration

πŸ“… Schedule: "after 10pm every weekday,every weekend,before 5am every weekday" in timezone America/New_York.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@jennifer-shehane
Copy link
Member

jennifer-shehane left a comment

Update notes

  • Used in cli package
  • We patch the "commander" method called when a user passed an unknown option. We want to print help for the current command and exit with an error - so it looks like the unit tests that are failing are likely failing due to update changes.

From changelog:

I've confirmed, the snapshot changes are due to whitespace fixes for help from commander.

  • Need to update snapshots to test against newly created snapshot after updating commander.

jennifer-shehane added some commits Feb 7, 2019

Merge branch 'develop' into renovate/commander-2.x
# Conflicts:
#	cli/package.json
@renovate

This comment has been minimized.

Copy link
Contributor Author

renovate bot commented Feb 7, 2019

PR has been edited

πŸ‘· This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over then you can add the label rebase to this PR and Renovate will reset/recreate it.

@jennifer-shehane jennifer-shehane merged commit ca821d7 into develop Feb 7, 2019

20 checks passed

ci/circleci: Linux lint Your tests passed on CircleCI!
Details
ci/circleci: Mac build Your tests passed on CircleCI!
Details
ci/circleci: Mac lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: desktop-gui-integration-tests-2x Your tests passed on CircleCI!
Details
ci/circleci: driver-integration-tests-3x Your tests passed on CircleCI!
Details
ci/circleci: run-launcher Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-8 Your tests passed on CircleCI!
Details
ci/circleci: server-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: server-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

@renovate renovate bot deleted the renovate/commander-2.x branch Feb 7, 2019

@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Mar 15, 2019

Released in 3.2.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.