Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger() accepts arbitrary event properties in options #3809

Merged
merged 1 commit into from Mar 26, 2019

Conversation

3 participants
@takuyahara
Copy link
Contributor

commented Mar 23, 2019

While docs say trigger() accepts arbitrary event properties in options, it is actually not allowed by TypeScript because ObjectLike is not intersected in type definition.

@CLAassistant

This comment has been minimized.

Copy link

commented Mar 23, 2019

CLA assistant check
All committers have signed the CLA.

@jennifer-shehane jennifer-shehane requested a review from bahmutov Mar 25, 2019

@@ -255,3 +255,19 @@ cy.screenshot('example', {
log: true,
blackout: []
})

namespace CypressTriggerTests {

This comment has been minimized.

Copy link
@bahmutov

bahmutov Mar 26, 2019

Collaborator

thank you for adding a type test

@bahmutov
Copy link
Collaborator

left a comment

looks good, has test

@bahmutov bahmutov merged commit e2e4542 into cypress-io:develop Mar 26, 2019

21 checks passed

ci/circleci: Linux lint Your tests passed on CircleCI!
Details
ci/circleci: Mac build Your tests passed on CircleCI!
Details
ci/circleci: Mac lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: desktop-gui-integration-tests-2x Your tests passed on CircleCI!
Details
ci/circleci: driver-integration-tests-3x Your tests passed on CircleCI!
Details
ci/circleci: lint-typescript Your tests passed on CircleCI!
Details
ci/circleci: run-launcher Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-8 Your tests passed on CircleCI!
Details
ci/circleci: server-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: server-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details

laurinenas added a commit to laurinenas/cypress that referenced this pull request Apr 28, 2019

@cypress-bot

This comment has been minimized.

Copy link

commented May 17, 2019

Released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.