Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: trigger() accepts arbitrary event properties in options #3809

Merged
merged 1 commit into from Mar 26, 2019

Conversation

@takuyahara
Copy link
Contributor

@takuyahara takuyahara commented Mar 23, 2019

While docs say trigger() accepts arbitrary event properties in options, it is actually not allowed by TypeScript because ObjectLike is not intersected in type definition.

@CLAassistant
Copy link

@CLAassistant CLAassistant commented Mar 23, 2019

CLA assistant check
All committers have signed the CLA.

@jennifer-shehane jennifer-shehane requested a review from bahmutov Mar 25, 2019
@@ -255,3 +255,19 @@ cy.screenshot('example', {
log: true,
blackout: []
})

namespace CypressTriggerTests {
Copy link
Collaborator

@bahmutov bahmutov Mar 26, 2019

thank you for adding a type test

Copy link
Collaborator

@bahmutov bahmutov left a comment

looks good, has test

@bahmutov bahmutov merged commit e2e4542 into cypress-io:develop Mar 26, 2019
21 checks passed
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented May 17, 2019

Released in 3.3.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

3 participants