Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] - Support Microsoft Edge (Chromium Based) #4203

Open
wants to merge 8 commits into
base: develop
from

Conversation

@YOU54F
Copy link

commented May 15, 2019

Proposal for Microsoft Edge (Chromium Based) Support in Cypress

Offical Microsoft Edge Insiders page here

Currently tested

  • Microsoft Edge for Mac (Canary Build)
    • Binary package here
  • Microsoft Edge for Mac (Dev Build)
    • Binary package here
  • Microsoft Edge for Windows 10 (Canary Build)
    • Binary package here
  • Microsoft Edge for Windows 10 (Dev Build)
    • Binary package here
  • Microsoft Edge for Linux (Canary Build)
    • Binary package currently unavalable
  • Microsoft Edge for Linux (Dev Build)
    • Binary package currently unavalable

Terminal output after change (in /packages/launcher)

➜  launcher git:(feat/msEdge) ✗ npm run build && node index.js
Alias tip: npmR build && npm install && node index.js

> @packages/launcher@0.0.0 build /Users/you54f/dev/saftest/githubrepos/forks/cypress/packages/launcher
> bin-up tsc --project .

Found /Users/you54f/dev/saftest/githubrepos/forks/cypress/node_modules/.bin/tsc

Launcher project exports
{ launch: [Function: launch],
  detect: [Function],
  detectByPath: [Function] }
⛔️ please use it as a module, not from CLI
detected 2 browsers
[ { name: 'chrome',
    family: 'chrome',
    displayName: 'Chrome',
    version: '74.0.3729.157',
    path:
     '/Applications/Google Chrome.app/Contents/MacOS/Google Chrome',
    majorVersion: '74' },
  { name: 'edge',
    family: 'chrome',
    displayName: 'Edge',
    version: '76.0.159.0',
    path:
     '/Applications/Microsoft Edge Canary.app/Contents/MacOS/Microsoft Edge Canary',
    majorVersion: '76' } ]

Screenshot 2019-05-14 at 22 59 23

Screenshot 2019-05-14 at 22 59 28

Screenshot 2019-05-14 at 23 11 03

Screenshot 2019-05-14 at 23 26 02

Screenshot 2019-05-14 at 23 26 12

@CLAassistant

This comment has been minimized.

Copy link

commented May 15, 2019

CLA assistant check
All committers have signed the CLA.

@YOU54F YOU54F force-pushed the YOU54F:feat/msEdge branch from ba80df2 to ce67d97 May 15, 2019

YOU54F added some commits May 16, 2019

package.json Outdated Show resolved Hide resolved

@jennifer-shehane jennifer-shehane changed the title [Proposal] - Support Microsoft Edge (Chromium Based) [WIP] - Support Microsoft Edge (Chromium Based) May 20, 2019

@YOU54F YOU54F force-pushed the YOU54F:feat/msEdge branch from 72daead to 5abd6eb May 20, 2019

@YOU54F

This comment has been minimized.

Copy link
Author

commented May 20, 2019

@jennifer-shehane thanks for reviewing, I am tracking and testing the edge packages at this github repo https://github.com/YOU54F/cypress-edge and have it working in CI at the moment :)

@coding-yogi

This comment has been minimized.

Copy link

commented Jun 10, 2019

Need additional changes to make it work on windows

@YOU54F

This comment has been minimized.

Copy link
Author

commented Jun 10, 2019

Need additional changes to make it work on windows

🙄 yep, hence why I’ve not marked the windows checkboxes in the first post.

@YOU54F

This comment has been minimized.

Copy link
Author

commented Jun 10, 2019

now supporting windows edge/dev ms edge builds

detected 3 browsers
[ { name: 'chrome',
    family: 'chrome',
    displayName: 'Chrome',
    version: '74.0.3729.169',
    path:
     'C:\\Program Files (x86)\\Google\\Chrome\\Application\\chrome.exe',
    majorVersion: '74' },
  { name: 'edgeCanary',
    family: 'chrome',
    displayName: 'Edge Canary',
    version: '77.0.186.0',
    path:
     'C:\\Users\\grung\\AppData\\Local\\Microsoft\\Edge SxS\\Application\\msedge.exe',
    majorVersion: '77' },
  { name: 'edgeDev',
    family: 'chrome',
    displayName: 'Edge Dev',
    version: '76.0.176.1',
    path:
     'C:\\Program Files (x86)\\Microsoft\\Edge Dev\\Application\\msedge.exe',
    majorVersion: '76' } ]
@YOU54F

This comment has been minimized.

Copy link
Author

commented Jun 11, 2019

@flotwig @bahmutov

Got Edge Dev & Edge Canary running on Windows now but I am having trouble building the binary.

It gets most of the way but fails when trying to perform a symlink for the electron package.

I am running git bash for windows (https://gitforwindows.org/)

All tasks completed successfully
1:07:54 AM #testVersion win32
testing dist package version
by calling: node index.js --version
in the folder C:\Users\grung\Documents\GitHub\cypress\dist\win32
app in C:\Users\grung\Documents\GitHub\cypress\dist\win32
built app version 3.3.0
1:07:56 AM #elBuilder win32
from C:\Users\grung\Documents\GitHub\cypress\dist\win32
into C:\Users\grung\Documents\GitHub\cypress\build\win32\Cypress
Packaging app for platform win32 x64 using electron v2.0.18
Error: EPERM: operation not permitted, symlink 'C:\Users\grung\AppData\Roaming\Cypress\cy\' -> 'C:\Users\grung\AppData\Local\Temp\electron-packager\win32-x64\Cypress-win32-x64\resources\app\packages\server\.cy'

How are you building it for windows? Via Appveyor?

BTW - Your contributing and deployment docs are quality! and the build process is 👌 kudos to all in the team.

@flotwig

This comment has been minimized.

Copy link
Member

commented Jun 11, 2019

@YOU54F Hmm, I don't know if I've seen that, but re-building Cypress on Windows from scratch always fixes whatever weird filesystem issue I'm having. Have you tried re-cloning Cypress and doing npm install over again? Might fix it.

@YOU54F

This comment has been minimized.

Copy link
Author

commented Jun 11, 2019

@YOU54F Hmm, I don't know if I've seen that, but re-building Cypress on Windows from scratch always fixes whatever weird filesystem issue I'm having. Have you tried re-cloning Cypress and doing npm install over again? Might fix it.

Cheers for the reply bud, I'll try it on my desktop machine when I'm home, I've got a few diff shells on that, and WSL (windows subsystem linux) so may have more luck. Will keep you posted 👍

YOU54F added some commits Jun 11, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
5 participants
You can’t perform that action at this time.