Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency ansi_up to version .x 🌟 #4331

Merged
merged 9 commits into from Dec 20, 2019

Conversation

@renovate
Copy link
Contributor

renovate bot commented May 29, 2019

This PR contains the following updates:

Package Type Update Change References
ansi_up dependencies major 1.3.0 -> 4.0.3 source

Release Notes

drudru/ansi_up

v4.0.3

Compare Source

Now supports escaped URL support - or 'terminal links' #​51
This is the proper solution to displaying URLs in a terminal.

Additional bug fixes were also merged in.

v4.0.2

Compare Source

v3.0.0

Compare Source

Now has proper Bold support.
Bug fixes and pull requests merged.

v2.0.3

Compare Source

v2.0.2

Compare Source

Bug fix from #​42 - fix the UMD support for webpack

v2.0.1

Compare Source

Bug fix from #​41 - adds support for another ANSI CSI code.

v2.0.0

Compare Source


Renovate configuration

📅 Schedule: "before 3am on the first day of the month" in timezone America/New_York.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Renovate Bot. View repository job log here.

@renovate

This comment has been minimized.

Copy link
Contributor Author

renovate bot commented May 30, 2019

PR has been edited

👷 This PR has received other commits, so Renovate will stop updating it to avoid conflicts or other problems. If you wish to abandon your changes and have Renovate start over you may click the "rebase" checkbox in the PR body/description.

…g rgb values in our tests
@jennifer-shehane

This comment has been minimized.

Copy link
Member

jennifer-shehane commented May 30, 2019

@brian-mann Honestly, I'm a little confused about the original intent of the ansi_to_html, is it supposed to have the ansi-* classes? Because the tests are failing, expecting RGB colors, but...we pass the use_classes option (which I think was never working in our ansi_up version).

https://github.com/cypress-io/cypress/blob/renovate/ansi_up-4.x/packages/server/lib/errors.coffee#L820

So, should the test change or the code change? The Dashboard app has stylings for ansi-* classes.

Edit: I'm confused by what I wrote here, the test is failing due to the opposite.

@cypress

This comment has been minimized.

Copy link

cypress bot commented Oct 2, 2019



Test summary

3587 0 47 0


Run details

Project cypress
Status Passed
Commit f36def1
Started Dec 20, 2019 11:20 AM
Ended Dec 20, 2019 11:24 AM
Duration 04:29 💡
OS Linux Debian - 9.11
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

jennifer-shehane left a comment

Is good now. Fixed the failing test by properly setting the class options

@jennifer-shehane jennifer-shehane merged commit c3ad1a3 into develop Dec 20, 2019
38 checks passed
38 checks passed
WIP Ready for review
Details
ci/circleci: Linux lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-binary Your tests passed on CircleCI!
Details
ci/circleci: build-npm-package Your tests passed on CircleCI!
Details
ci/circleci: desktop-gui-integration-tests-2x Your tests passed on CircleCI!
Details
ci/circleci: driver-integration-tests-chrome Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: reporter-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: run-launcher Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-8 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-8 Your tests passed on CircleCI!
Details
ci/circleci: server-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: server-performance-tests Your tests passed on CircleCI!
Details
ci/circleci: server-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: test binary as a non-root user Your tests passed on CircleCI!
Details
ci/circleci: test binary as a root user Your tests passed on CircleCI!
Details
ci/circleci: test-kitchensink Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
cypress: 2x-desktop-gui 402 tests passed in 02:16
Details
cypress: 5x-driver-chrome 3155 tests passed in 04:24
Details
cypress: reporter 30 tests passed in 00:45
Details
license/cla Contributor License Agreement is signed.
Details
@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Dec 26, 2019

Released in 3.8.1.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.