Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): Update dependency electron-context-menu to version 0.15.1 🌟 #5495

Merged
merged 1 commit into from Dec 2, 2019

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 28, 2019

This PR contains the following updates:

Package Type Update Change
electron-context-menu dependencies minor 0.11.0 -> 0.15.1

Release Notes

sindresorhus/electron-context-menu

v0.15.1

Compare Source

  • Fix showing Inspect Element menu item 9e9fd9a
  • Fix TypeScript definition 4d28a12

v0.15.0

Compare Source

Enhancements:

v0.14.0

Compare Source

  • Fix the "Save Image" label ID 4c8eb16
    If you localize the "Save Image" label, you need to update the ID from save to saveImage.

v0.13.0

Compare Source

Enhancements:

v0.12.1

Compare Source

v0.12.0

Compare Source

Breaking:

  • Require Electron 4 or later b075c7f
  • The function given to the prepend and append options now receive a defaultActions argument as the first argument. So the previous first and second argument are now second and third.
  • For TypeScript users only:
    • Refactor TypeScript definition to CommonJS compatible export (#​64) d447280
      • You need to change import contextMenu from 'electron-context-menu'; to import contextMenu = require('electron-context-menu');

Enhancements:


Renovate configuration

πŸ“… Schedule: "before 3am on the first day of the month" in timezone America/New_York.

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

♻️ Rebasing: Whenever PR becomes conflicted, or if you modify the PR title to begin with "rebase!".

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

Newsflash: Renovate has joined WhiteSource, and is now free for all use. Learn more or view updated terms and privacy policies.

@renovate renovate bot added renovate type: dependencies labels Oct 28, 2019
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Oct 28, 2019

Below are some guidelines Cypress uses when reviewing dependency updates.

Dependency Update Instructions

  • Read through the entire changelog of the dependency's changes. If a changelog is not available, check every commit made to the dependency. NOTE - do not rely on semver to indicate breaking changes - every product does not follow this standard.
  • Add a PR review comment noting any relevant changes in the dependency.
  • If any of the following requirements cannot be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

Dependency Updates Checklist

  • Code using the dependency has been updated to accommodate any breaking changes
  • The dependency still supports the version of Node that the package requires.
  • The PR been tagged with a release in ZenHub.
  • Appropriate labels have been added to the PR (for example: label type: breaking change if it is a breaking change)

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

This requires Electron 4+, which we now have in Cypress 3.5.0

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

  • This requires Electron 4+, which we now have in Cypress 3.5.0
  • We are not using the append or prepend method which was the other breaking change.
  • Functionally - this is totally broken. The 'Inspect Element' context menu is now disabled.

Screen Shot 2019-10-30 at 4 04 57 PM

I opened an issue here: sindresorhus/electron-context-menu#86

@renovate renovate bot force-pushed the renovate/electron-context-menu-0.x branch from cd99ee2 to 211c254 Compare Nov 1, 2019
@renovate renovate bot changed the title fix(deps): update dependency electron-context-menu to version 0.15.0 🌟 fix(deps): Update dependency electron-context-menu to version 0.15.0 🌟 Nov 1, 2019
@cypress
Copy link

@cypress cypress bot commented Nov 1, 2019



Test summary

3517 β€’ 0 β€’ 45 β€’ 0


Run details

Project cypress
Status Passed
Commit 7542b52
Started Dec 1, 2019 5:18 AM
Ended Dec 1, 2019 5:22 AM
Duration 03:41 πŸ’‘
OS Linux Debian - 9.8
Browser Multiple

View run in Cypress Dashboard ➑️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@renovate renovate bot force-pushed the renovate/electron-context-menu-0.x branch from 211c254 to 7542b52 Compare Dec 1, 2019
@renovate renovate bot changed the title fix(deps): Update dependency electron-context-menu to version 0.15.0 🌟 fix(deps): Update dependency electron-context-menu to version 0.15.1 🌟 Dec 1, 2019
@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Dec 2, 2019

This should have been fixed in 0.15.1 release, so requires a rereview. https://github.com/sindresorhus/electron-context-menu/releases/tag/v0.15.1

@jennifer-shehane jennifer-shehane self-requested a review Dec 2, 2019
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Verified the 'Inspect Element' context menu is now working in 0.15.1 of the dep. LGTM.

@jennifer-shehane jennifer-shehane merged commit 1cbf22a into develop Dec 2, 2019
38 checks passed
@renovate renovate bot deleted the renovate/electron-context-menu-0.x branch Dec 2, 2019
santoshyadavdev pushed a commit to santoshyadavdev/cypress that referenced this issue Dec 5, 2019
avallete pushed a commit to avallete/cypress that referenced this issue Dec 10, 2019
@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Dec 12, 2019

Released in 3.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renovate type: dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants