Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduced new error message for position:fixed and needs scroll. #5594

Merged
merged 2 commits into from Nov 26, 2019

Conversation

@sainthkh
Copy link
Contributor

sainthkh commented Nov 4, 2019

User facing changelog

New error message for position:fixed on an ancestor and an element needs scroll to be visible.

Additional details

  • Why was this change necessary?

Error message is unclear with undefined. So, created a new error message that explains why and possible solution.

  • What is affected by this change?

Not much. Added a test.

  • Any implementation details to explain?

N/A

How has the user experience changed?

Before:

After:
Screenshot from 2019-11-04 19-06-06

PR Tasks

@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Nov 4, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.
@jennifer-shehane jennifer-shehane requested a review from cypress-io/test-runner Nov 26, 2019
@andrew-codes andrew-codes self-assigned this Nov 26, 2019
@andrew-codes andrew-codes merged commit 146680e into cypress-io:develop Nov 26, 2019
35 checks passed
35 checks passed
WIP Ready for review
Details
ci/circleci: Linux lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-binary Your tests passed on CircleCI!
Details
ci/circleci: build-npm-package Your tests passed on CircleCI!
Details
ci/circleci: desktop-gui-integration-tests-2x Your tests passed on CircleCI!
Details
ci/circleci: driver-integration-tests-chrome Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: reporter-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: run-launcher Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-8 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-8 Your tests passed on CircleCI!
Details
ci/circleci: server-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: server-performance-tests Your tests passed on CircleCI!
Details
ci/circleci: server-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: test binary as a non-root user Your tests passed on CircleCI!
Details
ci/circleci: test binary as a root user Your tests passed on CircleCI!
Details
ci/circleci: test-kitchensink Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants
You can’t perform that action at this time.