Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaff querying.coffee and its test. #5643

Merged
merged 6 commits into from Dec 2, 2019

Conversation

@sainthkh
Copy link
Contributor

sainthkh commented Nov 8, 2019

Preparation for fixing #92.

NEVER SQUASH THIS PR.

@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Nov 8, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.
@sainthkh sainthkh changed the title Decaff querying.coffee and its test. Wip Decaff querying.coffee and its test. Nov 8, 2019
@sainthkh sainthkh force-pushed the sainthkh:issue-92-decaff branch from 2bcc9be to d6984d0 Nov 9, 2019
@sainthkh sainthkh changed the title Wip Decaff querying.coffee and its test. Decaff querying.coffee and its test. Nov 11, 2019
@sainthkh

This comment has been minimized.

Copy link
Contributor Author

sainthkh commented Nov 11, 2019

server-e2e-tests-electron-5 failed because of a flaky test. I ran the test 5+ times on my 18.04 ubuntu. It all passed.

@sainthkh

This comment has been minimized.

Copy link
Contributor Author

sainthkh commented Nov 27, 2019

Failed because of a flaky test.

Copy link
Member

jennifer-shehane left a comment

Please make sure to read through each line of converted code (also make sure eslint is on to catch simple mistakes). We want to maintain readability of the code, which is why converting to JS has not been a quick process of just convert and go.

I made some suggestions and highlighted some areas where the conversion was less than ideal for readability.

packages/driver/src/cy/commands/querying.js Outdated Show resolved Hide resolved
packages/driver/src/cy/commands/querying.js Outdated Show resolved Hide resolved
packages/driver/src/cy/commands/querying.js Outdated Show resolved Hide resolved
packages/driver/src/cy/commands/querying.js Outdated Show resolved Hide resolved
packages/driver/src/cy/commands/querying.js Outdated Show resolved Hide resolved
packages/driver/src/cy/commands/querying.js Outdated Show resolved Hide resolved
packages/driver/src/cy/commands/querying.js Outdated Show resolved Hide resolved
packages/driver/src/cy/commands/querying.js Outdated Show resolved Hide resolved
packages/driver/src/cy/commands/querying.js Outdated Show resolved Hide resolved
packages/driver/src/cy/commands/querying.js Outdated Show resolved Hide resolved
Copy link
Member

jennifer-shehane left a comment

Please make sure to read through each line of converted code (also make sure eslint is on to catch simple mistakes). We want to maintain readability of the code, which is why converting to JS has not been a quick process of just convert and go.

I made some suggestions and highlighted some areas where the conversion was less than ideal for readability.

@sainthkh sainthkh force-pushed the sainthkh:issue-92-decaff branch 2 times, most recently from 4a427e2 to bd32628 Nov 28, 2019
Fixed eslint errors and removed returns.

Minor fixes.
Fixed switches.
Removed returns.
@sainthkh sainthkh force-pushed the sainthkh:issue-92-decaff branch from bd32628 to d115aa7 Nov 28, 2019
@sainthkh

This comment has been minimized.

Copy link
Contributor Author

sainthkh commented Nov 28, 2019

@jennifer-shehane Thanks for the long review. Based on your review, I've created a checklist here.

@sainthkh

This comment has been minimized.

Copy link
Contributor Author

sainthkh commented Nov 29, 2019

@jennifer-shehane Ah, I forgot to mention this.

Everything you told me is fixed and merged into the last commit.

@jennifer-shehane

This comment has been minimized.

Copy link
Member

jennifer-shehane commented Dec 2, 2019

@sainthkh This is so great 😍

@bahmutov Thoughts on adding this at a PR comment when there is a PR with commit messages prepended with decaffeinate:? Is this possible? #2690 (comment)

Copy link
Member

jennifer-shehane left a comment

Great! Thank you!

@jennifer-shehane jennifer-shehane merged commit be3f1ab into cypress-io:develop Dec 2, 2019
35 checks passed
35 checks passed
WIP Ready for review
Details
ci/circleci: Linux lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-binary Your tests passed on CircleCI!
Details
ci/circleci: build-npm-package Your tests passed on CircleCI!
Details
ci/circleci: desktop-gui-integration-tests-2x Your tests passed on CircleCI!
Details
ci/circleci: driver-integration-tests-chrome Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: reporter-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: run-launcher Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-8 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-8 Your tests passed on CircleCI!
Details
ci/circleci: server-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: server-performance-tests Your tests passed on CircleCI!
Details
ci/circleci: server-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: test binary as a non-root user Your tests passed on CircleCI!
Details
ci/circleci: test binary as a root user Your tests passed on CircleCI!
Details
ci/circleci: test-kitchensink Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
license/cla Contributor License Agreement is signed.
Details
@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Dec 12, 2019

Released in 3.8.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.