Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade font-awesome to 5+ #5822

Merged
merged 6 commits into from Dec 3, 2019
Merged

Upgrade font-awesome to 5+ #5822

merged 6 commits into from Dec 3, 2019

Conversation

@jennifer-shehane
Copy link
Member

jennifer-shehane commented Nov 29, 2019

User facing changelog

N/A

Additional details

  • Replaced all ‘fa’ uses with ‘fas’ or ‘far’ respectively
  • Rename icons that have changed name
  • Remove scss font-awesome 4 references and replace with font-awesome 5
  • Update npm package that is installed

How has the user experience changed?

The icons should look a bit bolder.

But essentially this will be nicer for contributors, having an up to date font-awesome docs to reference and also more icons to choose from. I thought the firefox icon looked nicer especially.

Before

Screen Shot 2019-12-03 at 10 31 59 PM
Screen Shot 2019-12-03 at 10 32 08 PM

After

Screen Shot 2019-12-03 at 10 30 59 PM
Screen Shot 2019-12-03 at 10 31 16 PM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • [NA] Has a PR for user-facing changes been opened in cypress-documentation?
  • [NA] Have API changes been updated in the type definitions?
  • [NA] Have new configuration options been added to the cypress.schema.json?
- replace all ‘fa’ uses with ‘fas’ or ‘far’ respectively
- rename icons that required renaming
- remove scss font-awesome 4 references and replace with font-awesome 5
- update npm package that is installed
@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Nov 29, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.
@jennifer-shehane jennifer-shehane changed the title Upgrade font-awesome to 5+ [WIP] Upgrade font-awesome to 5+ Nov 29, 2019
@jennifer-shehane jennifer-shehane requested a review from chrisbreiding Nov 29, 2019
@cypress

This comment has been minimized.

Copy link

cypress bot commented Nov 29, 2019



Test summary

3517 0 45 0


Run details

Project cypress
Status Passed
Commit 0896b30
Started Dec 3, 2019 3:15 PM
Ended Dec 3, 2019 3:19 PM
Duration 04:16 💡
OS Linux Debian - 9.8
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Contributor

chrisbreiding left a comment

I went through and manually checked all the places we use icons and they all look to be good now.

@jennifer-shehane jennifer-shehane changed the title [WIP] Upgrade font-awesome to 5+ Upgrade font-awesome to 5+ Dec 3, 2019
@jennifer-shehane jennifer-shehane merged commit bbd519a into develop Dec 3, 2019
38 checks passed
38 checks passed
WIP Ready for review
Details
ci/circleci: Linux lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-binary Your tests passed on CircleCI!
Details
ci/circleci: build-npm-package Your tests passed on CircleCI!
Details
ci/circleci: desktop-gui-integration-tests-2x Your tests passed on CircleCI!
Details
ci/circleci: driver-integration-tests-chrome Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: reporter-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: run-launcher Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-8 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-8 Your tests passed on CircleCI!
Details
ci/circleci: server-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: server-performance-tests Your tests passed on CircleCI!
Details
ci/circleci: server-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: test binary as a non-root user Your tests passed on CircleCI!
Details
ci/circleci: test binary as a root user Your tests passed on CircleCI!
Details
ci/circleci: test-kitchensink Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
cypress: 2x-desktop-gui 395 tests passed in 02:02
Details
cypress: 5x-driver-chrome 3092 tests passed in 04:10
Details
cypress: reporter 30 tests passed in 00:44
Details
license/cla Contributor License Agreement is signed.
Details
Bkucera added a commit that referenced this pull request Dec 3, 2019
This reverts commit bbd519a.
santoshyadav198613 added a commit to santoshyadav198613/cypress that referenced this pull request Dec 5, 2019
* Upgrade font-awesome to 5+

- replace all ‘fa’ uses with ‘fas’ or ‘far’ respectively
- rename icons that required renaming
- remove scss font-awesome 4 references and replace with font-awesome 5
- update npm package that is installed

* fix failing spec

* include all the necssary scss

* fix/improve tests

* fix icon references

* fix some icons


Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>
avallete added a commit to avallete/cypress that referenced this pull request Dec 10, 2019
* Upgrade font-awesome to 5+

- replace all ‘fa’ uses with ‘fas’ or ‘far’ respectively
- rename icons that required renaming
- remove scss font-awesome 4 references and replace with font-awesome 5
- update npm package that is installed

* fix failing spec

* include all the necssary scss

* fix/improve tests

* fix icon references

* fix some icons


Co-authored-by: Chris Breiding <chrisbreiding@gmail.com>
@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Dec 12, 2019

Released in 3.8.0.

@cypress-io cypress-io locked as resolved and limited conversation to collaborators Dec 16, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
2 participants
You can’t perform that action at this time.