Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Electron upgrade #5849

Merged
merged 25 commits into from Dec 11, 2019
Merged

Electron upgrade #5849

merged 25 commits into from Dec 11, 2019

Conversation

flotwig
Copy link
Member

@flotwig flotwig commented Dec 2, 2019

User facing changelog

  • Upgraded Electron from 5.0.10 to 7.1.4. This bumps the internal Node version to 12.8.1 and the internal Chromium version to 78.0.3904.113.

Additional details

  • depends on #5850 getting merged - most of the diff is this

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Dec 2, 2019

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@cypress
Copy link

@cypress cypress bot commented Dec 2, 2019



Test summary

3573 0 47 0


Run details

Project cypress
Status Passed
Commit decb35b
Started Dec 11, 2019 3:59 PM
Ended Dec 11, 2019 4:04 PM
Duration 05:02 💡
OS Linux Debian - 9.11
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig changed the title [WIP] Electron upgrade Electron upgrade Dec 2, 2019
@flotwig flotwig requested a review from brian-mann Dec 2, 2019
@flotwig flotwig requested a review from Dec 8, 2019
executors:
# the Docker image with Cypress dependencies and Chrome browser
cy-doc:
docker:
- image: cypress/browsers:node12.0.0-chrome73
- image: cypress/browsers:node12.8.1-chrome78-ff70
Copy link
Member

@jennifer-shehane jennifer-shehane Dec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this PR updating the Node version? Aren't we using 12.0.0, don't we want to test against that?

Also, if this is a convenience thing - probably highlights why our docker images combinations are problematic for our own users. :P

Copy link
Member Author

@flotwig flotwig Dec 10, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates the bundled Node version to 12.8.1 (Electron 5 -> 7). The node version we use in CI needs to match this, since the unit + integrations tests (of Electron code) all run in node in CI, not electron. We could use electron-mocha to eliminate this requirement, but currently that's the way it is.

@flotwig flotwig requested a review from Dec 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants