Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More decaff for issue 678 #6075

Merged
merged 3 commits into from Jan 9, 2020
Merged

Conversation

sainthkh
Copy link
Collaborator

@sainthkh sainthkh commented Jan 1, 2020

  • More preparation for #678

NEVER SQUASH THIS PR.

@cypress-bot
Copy link

@cypress-bot cypress-bot bot commented Jan 1, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.

@sainthkh sainthkh changed the title WIP More decaff for issue 678 More decaff for issue 678 Jan 2, 2020
@jennifer-shehane jennifer-shehane requested a review from Jan 2, 2020
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Some minor things to look at. Should be good to merge after that.

packages/driver/src/cy/assertions.js Outdated Show resolved Hide resolved
packages/driver/src/cy/assertions.js Outdated Show resolved Hide resolved
packages/driver/src/cy/assertions.js Outdated Show resolved Hide resolved
packages/driver/src/cy/assertions.js Outdated Show resolved Hide resolved
packages/driver/src/cy/assertions.js Show resolved Hide resolved
packages/driver/src/cypress/chai_jquery.js Outdated Show resolved Hide resolved
packages/driver/src/cypress/chai_jquery.js Outdated Show resolved Hide resolved
packages/driver/src/cypress/chai_jquery.js Outdated Show resolved Hide resolved
packages/driver/src/cypress/mocha.js Show resolved Hide resolved
packages/driver/src/cypress/mocha.js Outdated Show resolved Hide resolved
@sainthkh
Copy link
Collaborator Author

@sainthkh sainthkh commented Jan 9, 2020

I was again careless about the translated code quality. Thank you for thorough review.

  1. The two arrow functions are originally arrow functions in CoffeeScript code.
  2. I decided to return cmds and setSubjectAndSkip function. In original CoffeeScript code, it was a copy of that array. It doesn't matter because setSubjectAndSkip is only used in then() function without using its return value.

@jennifer-shehane jennifer-shehane merged commit 7875966 into cypress-io:develop Jan 9, 2020
35 checks passed
@jennifer-shehane
Copy link
Member

@jennifer-shehane jennifer-shehane commented Jan 9, 2020

I did not squash this commit!
Screen Shot 2020-01-09 at 11 43 13 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants