Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean-deps without dependencies on packages #6774

Merged
merged 2 commits into from Mar 23, 2020

Conversation

@andrew-codes
Copy link
Contributor

andrew-codes commented Mar 18, 2020

User facing changelog

N/A

Additional details

When in a situtation where the developer's node_modules are incorrect or corrupted, the yarn clean-deps script is intended to remove/clean all node_modules. However, it previously required the prescense of a node_module, lerna. This removes that dependency, so that node_modules may be cleaned even after they have been corrupted.

An example use case, as mentioned in #6731, is accidently running npm i.

How has the user experience changed?

N/A

PR Tasks

N/A

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?
Removes all node_modules without dependnecy on lerna or any other package.
@cypress-bot

This comment has been minimized.

Copy link

cypress-bot bot commented Mar 18, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).

Functionality

  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.

Maintainability

  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).

Quality

  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.

Internal

  • The original issue has been tagged with a release in ZenHub.
@andrew-codes andrew-codes requested review from jennifer-shehane, cypress-io/test-runner and CypressJoseph and removed request for cypress-io/test-runner and CypressJoseph Mar 18, 2020
@cypress

This comment has been minimized.

Copy link

cypress bot commented Mar 18, 2020



Test summary

7018 0 98 0


Run details

Project cypress
Status Passed
Commit d519b1b
Started Mar 18, 2020 2:13 PM
Ended Mar 18, 2020 2:20 PM
Duration 06:44 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

jennifer-shehane left a comment

👍

@jennifer-shehane jennifer-shehane merged commit bfc93aa into develop Mar 23, 2020
56 checks passed
56 checks passed
WIP Ready for review
Details
ci/circleci: Linux lint Your tests passed on CircleCI!
Details
ci/circleci: build Your tests passed on CircleCI!
Details
ci/circleci: build-binary Your tests passed on CircleCI!
Details
ci/circleci: build-npm-package Your tests passed on CircleCI!
Details
ci/circleci: cli-visual-tests Your tests passed on CircleCI!
Details
ci/circleci: desktop-gui-integration-tests-2x Your tests passed on CircleCI!
Details
ci/circleci: desktop-gui-visual-tests Your tests passed on CircleCI!
Details
ci/circleci: driver-integration-tests-chrome Your tests passed on CircleCI!
Details
ci/circleci: driver-integration-tests-firefox Your tests passed on CircleCI!
Details
ci/circleci: lint-types Your tests passed on CircleCI!
Details
ci/circleci: reporter-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: run-launcher Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-chrome-8 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-electron-8 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-firefox-1 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-firefox-2 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-firefox-3 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-firefox-4 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-firefox-5 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-firefox-6 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-firefox-7 Your tests passed on CircleCI!
Details
ci/circleci: server-e2e-tests-firefox-8 Your tests passed on CircleCI!
Details
ci/circleci: server-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: server-performance-tests Your tests passed on CircleCI!
Details
ci/circleci: server-unit-tests Your tests passed on CircleCI!
Details
ci/circleci: test binary as a non-root user Your tests passed on CircleCI!
Details
ci/circleci: test binary as a root user Your tests passed on CircleCI!
Details
ci/circleci: test-kitchensink Your tests passed on CircleCI!
Details
ci/circleci: test-npm-module-on-minimum-node-version Your tests passed on CircleCI!
Details
ci/circleci: ui-components-integration-tests Your tests passed on CircleCI!
Details
ci/circleci: unit-tests Your tests passed on CircleCI!
Details
continuous-integration/appveyor/branch AppVeyor build succeeded
Details
continuous-integration/appveyor/pr AppVeyor build succeeded
Details
cypress: 2x-desktop-gui 427 tests passed in 02:37
Details
cypress: 5x-driver-chrome 3272 tests passed in 04:18
Details
cypress: 5x-driver-firefox 3270 tests passed in 06:17
Details
cypress: reporter 37 tests passed in 00:31
Details
cypress: ui-components 12 tests passed in 00:17
Details
license/cla Contributor License Agreement is signed.
Details
percy/cypress Visual review automatically approved, no visual changes found.
Details
percy/cypress-cli Visual review automatically approved, no visual changes found.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

2 participants
You can’t perform that action at this time.