Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decaf cdp automation spec #6833

merged 4 commits into from Mar 25, 2020

Decaf cdp automation spec #6833

merged 4 commits into from Mar 25, 2020


Copy link

@flotwig flotwig commented Mar 24, 2020

Partially addresses #2690

Copy link

cypress-bot bot commented Mar 24, 2020

Thanks for the contribution! Below are some guidelines Cypress uses when doing PR reviews.

  • Please write [WIP] in the title of your Pull Request if your PR is not ready for review - someone will review your PR as soon as the [WIP] is removed.
  • Please familiarize yourself with the PR Review Checklist and feel free to make updates on your PR based on these guidelines.

PR Review Checklist

If any of the following requirements can't be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

User Experience

  • The feature/bugfix is self-documenting from within the product.
  • The change provides the end user with a way to fix their problem (no dead ends).


  • The code works and performs its intended function with the correct logic.
  • Performance has been factored in (for example, the code cleans up after itself to not cause memory leaks).
  • The code guards against edge cases and invalid input and has tests to cover it.


  • The code is readable (too many nested 'if's are a bad sign).
  • Names used for variables, methods, etc, clearly describe their function.
  • The code is easy to understood and there are relevant comments explaining.
  • New algorithms are documented in the code with link(s) to external docs (flowcharts, w3c, chrome, firefox).
  • There are comments containing link(s) to the addressed issue (in tests and code).


  • The change does not reimplement code.
  • There's not a module from the ecosystem that should be used instead.
  • There is no redundant or duplicate code.
  • There are no irrelevant comments left in the code.
  • Tests are testing the code’s intended functionality in the best way possible.


  • The original issue has been tagged with a release in ZenHub.

@flotwig flotwig requested review from a team, chrisbreiding and CypressJoseph and removed request for a team March 24, 2020 20:48
Copy link

cypress bot commented Mar 24, 2020

Test summary

7024 0 98 0

Run details

Project cypress
Status Passed
Commit 56bbf5c
Started Mar 24, 2020 8:43 PM
Ended Mar 24, 2020 8:48 PM
Duration 05:45 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@brian-mann brian-mann self-requested a review March 25, 2020 01:21
@brian-mann brian-mann merged commit aee0517 into develop Mar 25, 2020
Copy link

cypress-bot bot commented Mar 30, 2020

Released in 4.3.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.3.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Mar 30, 2020
@flotwig flotwig deleted the decaf-cdp-automation-spec branch January 24, 2022 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants