Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency cookie-parser to version 1.4.5 馃専 #7389

Merged
merged 1 commit into from May 18, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented May 18, 2020

This PR contains the following updates:

Package Type Update Change
cookie-parser dependencies patch 1.4.4 -> 1.4.5

Release Notes

expressjs/cookie-parser

v1.4.5

Compare Source

==================

  • deps: cookie@0.4.0

Renovate configuration

馃搮 Schedule: "before 3am on the first day of the month" in timezone America/New_York.

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added renovate Triggered by renovatebot type: dependencies labels May 18, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented May 18, 2020

Below are some guidelines Cypress uses when reviewing dependency updates.

Dependency Update Instructions

  • Read through the entire changelog of the dependency's changes. If a changelog is not available, check every commit made to the dependency. NOTE - do not rely on semver to indicate breaking changes - every product does not follow this standard.
  • Add a PR review comment noting any relevant changes in the dependency.
  • If any of the following requirements cannot be met, leave a comment in the review selecting 'Request changes', otherwise 'Approve'.

Dependency Updates Checklist

  • Code using the dependency has been updated to accommodate any breaking changes
  • The dependency still supports the version of Node that the package requires.
  • The PR been tagged with a release in ZenHub.
  • Appropriate labels have been added to the PR (for example: label type: breaking change if it is a breaking change)

@cypress
Copy link

cypress bot commented May 18, 2020



Test summary

7394 0 104 0


Run details

Project cypress
Status Passed
Commit 09965bb
Started May 18, 2020 7:54 AM
Ended May 18, 2020 8:00 AM
Duration 05:56 馃挕
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard 鉃★笍


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@jennifer-shehane
Copy link
Member

@flotwig Updates cookie dep which seems to have added support for SameSite=None jshttp/cookie@6e5b36b

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, doesn't look like it affects anything. tough-cookie is what is used for parsing and manipulating cookies in the proxy layer, cookie-parser is only used to set req.cookies so we can see __cypress.unload and __cypress.initial cookies.

@flotwig flotwig merged commit 4ea613e into develop May 18, 2020
@renovate renovate bot deleted the renovate/cookie-parser-1.x branch May 18, 2020 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
renovate Triggered by renovatebot type: dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants