New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add quiet
cli arg/module option
#7714
Conversation
Thanks for taking the time to open a PR!
|
0f01529
to
a14e461
Compare
--quiet mode to disable the verbose results to stdout but still use specified formatter
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice. Thanks for the contribution!
We'll want to make sure this covers passing quiet
to the Module API also.
We'll have someone from the team more formally review, just noted a typo I found for now.
Co-authored-by: Jennifer Shehane <shehane.jennifer@gmail.com>
Cypress module support for --quiet
Thank you for taking a look so quickly, I have added a test which verifies the quiet option can be passed in via the module api. |
Dismissing my previous review as resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only functional change that needs to be made is to remove quiet
as a config option. Since we want to use it only as a CLI argument/module option, it shouldn't be passed around or exposed as a config var.
Co-authored-by: Zach Bloomquist <github@chary.us>
208f943
to
14498b1
Compare
Address feedback, thanks
I can't get the ci jobs to pass consistently, I think it got worse when I merged the develop branch back in, but I don't think these failures are related to my changes |
@slt Yeah, there is some unrelated flake in those tests that we're working on fixing. |
@slt can you enable this option so I can push a commit to your branch? https://help.github.com/en/github/collaborating-with-issues-and-pull-requests/allowing-changes-to-a-pull-request-branch-created-from-a-fork#enabling-repository-maintainer-permissions-on-existing-pull-requests going to clean up the run.js code and then merge this |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. opened a separate PR for minor cleanup #7777
quiet
cli arg/module option
Thank you @flotwig @jennifer-shehane |
User facing changelog
--quiet
flag available that will silence any Cypress specific output from stdout.Additional details
When I saw how noisy our CI was with cypress tests, I assumed by changing the reporter I could make it a little less verbose, but this output comes no matter what reporter is configured.
This pull requests adds --quiet as a option which disables the output for:
This should just leave you with whatever the configured reporter is
How has the user experience changed?
PR Tasks
cypress-documentation
? docs: addquiet
cli arg/module api flag cypress-documentation#2903cypress.schema.json
?