Fix shadow dom visibility hang #7893
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makes diagnosing bugs in terminal condition easier because it causes a 'Maximum call stack size exceeded' error pointing to the offending function instead of hanging with no indication where it's happening
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
jennifer-shehane
approved these changes
Jul 7, 2020
JessicaSachs
reviewed
Jul 7, 2020
| const isWithinShadowRoot = (node: HTMLElement) => { | ||
| return node.getRootNode().toString() === '[object ShadowRoot]' | ||
| return isShadowRoot(node.getRootNode()) |
There was a problem hiding this comment.
👍 nice, I know this is something James was hoping to fix in his original PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
Additional details
More information in this comment on the original issue. The fix itself is preventing an infinite loop and is pretty straightforward.
I also refactored the code to use recursion instead of
whileloops, since awhileloop will hang the browser, making it difficult to debug. If a recursive function infinitely recurses, it usually causes aMaximum stack...error pretty quickly without hanging the browser and the stack for the error points directly to the offending function.PR Tasks
cypress-documentation?type definitions?cypress.schema.json?