Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency proxy-from-env to version 1.1.0 馃専 #7900

Merged
merged 1 commit into from Jul 8, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Jul 7, 2020

This PR contains the following updates:

Package Type Update Change
proxy-from-env dependencies minor 1.0.0 -> 1.1.0

Release Notes

Rob--W/proxy-from-env

v1.1.0

Compare Source


Renovate configuration

馃搮 Schedule: "before 3am on the first day of the month" in timezone America/New_York.

馃殾 Automerge: Disabled by config. Please merge this manually once you are satisfied.

鈾伙笍 Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

馃敃 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot added renovate Triggered by renovatebot type: dependencies labels Jul 7, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 7, 2020

See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

@cypress
Copy link

cypress bot commented Jul 7, 2020



Test summary

3537 0 57 0


Run details

Project cypress
Status Passed
Commit c6f151a
Started Jul 7, 2020 7:02 AM
Ended Jul 7, 2020 7:09 AM
Duration 07:01 馃挕
OS Linux Debian - 10.1
Browser Firefox 74

View run in Cypress Dashboard 鉃★笍


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should now also detect proxy config set by process.env.npm_config_https_proxy, process.env.npm_config_http_proxy, and process.env.npm_config_no_proxy. cc @flotwig

@jennifer-shehane jennifer-shehane merged commit 4618650 into develop Jul 8, 2020
@renovate renovate bot deleted the renovate/proxy-from-env-1.x branch July 8, 2020 04:17
@flotwig
Copy link
Contributor

flotwig commented Jul 10, 2020

@jennifer-shehane We do this in the server already, so this update shouldn't affect users 馃憤

const mergeNpmProxyVars = () => {
// copy npm's `proxy` and `https-proxy` config if they are set
// https://github.com/cypress-io/cypress/pull/4705
[
['npm_config_proxy', 'HTTP_PROXY'],
['npm_config_https_proxy', 'HTTPS_PROXY'],
].forEach(([from, to]) => {
if (!falsyEnv(process.env[from]) && _.isUndefined(process.env[to])) {
debug('using npm\'s %s as %s', from, to)
process.env[to] = process.env[from]
}
})
}

I'm surprised Rob--W updated the package, I thought he considered it "complete"

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Jul 21, 2020

Released in 4.11.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v4.11.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Jul 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
renovate Triggered by renovatebot type: dependencies
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants