New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
check for undefined values on setPluginResolvedOn function #7960
Conversation
Thanks for taking the time to open a PR!
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the contribution! Could you please sign our CLA?
Additionally, we will need some tests written to verify this new behavior.
There is a Contributing Guide that covers how to contribute and get Cypress running locally here: https://github.com/cypress-io/cypress/blob/develop/.github/CONTRIBUTING.md
Let us know if you have trouble getting the tests running locally.
I will do my best since is my first contribution to an open source project 👍 |
@jmsansan Thanks for signing the CLA, unfortunately the author of all of the commits does not match the email address on your GitHub account. There are 2 commits, one made by Jose Sanchez the other made by jmsansan. https://github.com/cypress-io/cypress/pull/7960/commits Our CLA bot gets confused when they don't match. Here are some solutions to fixing when commits are linked to another wrong user: https://help.github.com/articles/why-are-my-commits-linked-to-the-wrong-user/ |
Signed-off-by: Jose Sanchez <jose.sanchez@insendi.com>
@jennifer-shehane |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I manually tested the given examples in the original issue. They no longer error. Additionally, they are all available properties on the Cypress.config()
as expected.
The configuration in the Settings also displays the objects and arrays correctly appended to the config.
Looks great. Thanks for the contribution! 💯
@jennifer-shehane should this PR also resolve #7002 and #1736 |
@mccataldo Yes! It does appear to have also fixed those issues. Nice catch 👍 I'll update those other issues to reflect that they've been fixed. |
User facing changelog
Fixed a bug where recursion function setPluginResolvedOn could receive undefined on resolvedObj parameter.