Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add tests for shadow dom traversal methods, fix issues #8202

merged 7 commits into from Aug 13, 2020


Copy link

@chrisbreiding chrisbreiding commented Aug 6, 2020

User facing changelog

  • Added support for .parent() and .parentsUntil() as well as passing a selector to .parents() when the subject is in the shadow dom.

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?

Co-authored-by: Zach Panzarino <>
Copy link

cypress-bot bot commented Aug 6, 2020

Thanks for taking the time to open a PR!

Copy link

cypress bot commented Aug 6, 2020

Test summary

8023 0 130 2

Run details

Project cypress
Status Passed
Commit c8871d6
Started Aug 11, 2020 6:51 PM
Ended Aug 11, 2020 6:57 PM
Duration 06:06 💡
OS Linux Debian - 10.1
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@chrisbreiding chrisbreiding changed the title fix: Add tests for shadow dom parents with selector, fix issues fix: Add tests for shadow dom traversal methods, fix issues Aug 6, 2020
@chrisbreiding chrisbreiding marked this pull request as ready for review August 11, 2020 19:50
Copy link

@panzarino panzarino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests cover a ton of different cases, LGTM

@chrisbreiding chrisbreiding merged commit 14e13f3 into develop Aug 13, 2020
66 of 67 checks passed
Copy link

cypress-bot bot commented Aug 20, 2020

Released in 5.0.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.0.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Aug 20, 2020
@chrisbreiding chrisbreiding deleted the tr-217-shadow-dom-parents-with-selector branch April 5, 2022 18:29
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants