Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(deps): update dependency electron to version 10.1.3 🌟 #8406

Merged
merged 2 commits into from Sep 29, 2020

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Aug 25, 2020

Fixes #8399

User-facing changelog

  • Fixed an issue introduced in 5.0.0 where the chromeWebSecurity option had no effect in Electron.
  • Upgraded Electron to 10.1.3. This upgrades the bundled Chromium version to 85 and the bundled Node version to 12.16.3.

This PR contains the following updates:

Package Type Update Change
electron devDependencies major 9.2.1 -> 10.1.3

Release Notes

electron/electron

v10.1.3

Compare Source

Release Notes for v10.1.3

Fixes

  • Fixed CORS not being disabled by webSecurity: false. #​25503 (Also in 9, 10, 11)
  • Fixed ready-to-show event not emitted on some machines. #​25476 (Also in 9, 10, 11)
  • Fixed a crash in app.importCertificate() on Linux. #​25536 (Also in 9, 10, 11)
  • Fixed a crash when closing window in an event listener after exiting fullscreen on macOS. #​25604 (Also in 10, 11)
  • Fixed an issue that could cause a normally-exiting process to fail with an "illegal access" message and exit code 7. #​25458 (Also in 8, 9, 10, 11)
  • Fixed an issue where an error would be displayed when using webContents.print() if no default was set and no device name provided. #​25606 (Also in 9, 10, 11)
  • Fixed an issue where multiple calls to window.print() could cause a crash. #​25530
  • Fixed an issue where pageRanges was not properly honored when printing. #​25597 (Also in 10)
  • Fixed crashes caused by attempting to modify destroyed views. #​25511 (Also in 9, 10, 11)
  • Fixed the remote-debugging-port discovery page showing garbled text. #​25601 (Also in 10, 11)
  • Updated Node root certs to use NSS 3.56. #​25361 (Also in 8, 9, 10, 11)

Other Changes

Unknown

  • Fixed extension background page devtools not being openable. #​25566 (Also in 9, 10, 11)

v10.1.2

Compare Source

Release Notes for v10.1.2

Fixes

  • Added missing module delay loads on windows to reduce per process reference set impact. #​25435 (Also in 9, 10, 11)
  • Fixed a crash in the renderer process when invoking the Badging API. #​25369 (Also in 9, 10, 11)
  • Fixed an issue where document.hasFocus and document.activeElement would be inconsistent upon showing a window that was initially created with show: false. #​25330 (Also in 10, 11)
  • Fixed client_id file being generated in the working directory for node child process. #​25309 (Also in 9, 10, 11)
  • Fixed multiple dock icons being left in system when calling dock.show/hide on macOS. #​25299 (Also in 8, 9, 10, 11)

Other Changes

Unknown

v10.1.1

Compare Source

Release Notes for v10.1.1

Fixes

  • Fixed an issue where filters set in dialogs on macOS would have nondeterministic ordering. #​25192
  • Fixed network permission error when there are multiple WebContents sharing same session are created with web security disabled. #​25178
  • Fixed the following issues for frameless when maximized on Windows:
  • Unreachable task bar when auto hidden with position top
  • 1px extending to secondary monitor
  • 1px overflowing into taskbar at certain resolutions
  • White line on top of window under 4k resolutions. #​25216

Other Changes

Unknown

  • Fixed issue where clicking notifications would no longer dismiss them as expected. #​25246

v10.1.0

Compare Source

Release Notes for v10.1.0

Features

  • Added visualEffectState option to BrowserWindows to allow customization of vibrancy effect state on macOS. #​25106
  • Added app.createThumbnailFromPath() API that returns a preview image of a file given its file path and a maximum thumbnail size. #​25072
  • Added back a previously broken visibleOnFullScreen option for setVisibleOnAllWorkspaces. #​25125
  • Added the currencyCode field that Apple's StoreKit in-app-purchasing library provides but has not been added to the Product object that inAppPurchase.getProducts returns. #​25084

Fixes

v10.0.1

Compare Source

Release Notes for v10.0.1

Fixes

  • Fixed powerMonitor not emitting suspend/resume events on some Windows machines. #​25111
  • Fixed an issue where notifications with a reply button could potentially be destroyed too early when a user clicked on the notification body before replying. #​25100
  • Fixed an issue where some apps might be rejected from the Mac App Store owing to a private font-related API added in Chromium. #​25137
  • Fixed window size being changed after unmaximizing. #​25132

Other Changes

v10.0.0

Compare Source

Release Notes for v10.0.0

Stack Upgrades

Breaking Changes

  • Changed the default value of 'enableRemoteModule' to false. #​22091
  • Changed the default value of app.allowRendererProcessReuse to true, this will prevent loading of non-context-aware native modules in renderer processes. See #​18397 for more information on this change. #​22336
  • Fixed the positioning of window buttons on MacOS when the OS locale is set to an RTL language (like Arabic or Hebrew). Frameless window apps may have to account for this change while styling their windows. #​22016

Features

  • Added contents.getBackgroundThrottling() method and contents.backgroundThrottling property. #​21036
  • Added a sameSite property to the Cookie structure allowing you to get and set the same site policy for cookies. #​22789
  • Added new render-process-gone event on app to replace the renderer-process-crashed event. #​23560
  • Added new render-process-gone event to replace the crashed event. #​23096
  • Added new useSessionCookies flag to net requests to allow them to use the session cookie store. #​22704
  • Added support for MessagePort in the main process. #​22404
  • Added support for the 'compress' option of crashReporter on Linux. #​23597
  • Added the 'onclose' event to MessagePort and MessagePortMain. #​22532
  • Added the ability to get the "Recent" folder on Windows with app.getPath('recent'). #​23381
  • BrowserWindow darkTheme option now defaults to nativeTheme.shouldUseDarkColors. #​20138
  • Can now check if a given session is persistent by calling the ses.isPersistent() API. #​22622
  • Deprecated uncompressed crash uploads in crashReporter. #​23598
  • Enable native Electron handling and passing of Node.js cli options. #​21110
  • Enhanced window.open functionality with the ability to handle POST data in the new-window event. #​19703
  • Exposed the desktopCapturer module in the main process. #​23548
  • The position of nested touch bars inherited from Chromium can now be customized (macOS). #​22270
  • Added V8 crash message and location information to crashReport parameters. #​24866
  • Removed the deprecated currentlyLoggingPath property of netLog. Additionally, netLog.stopLogging no longer returns the path to the recorded log. #​22732
  • Added disableDialogs option to WebPreferences. #​22395 (Also in 8, 9)
  • Added fullScreen property support for BrowserWindows. #​23145 (Also in 9)
  • Added rateLimit and compress options to crashReporter. #​23062
  • Added session.listWordsFromSpellCheckerDictionary API to list custom words in the dictionary. #​22101 (Also in 9)
  • Added session.removeWordFromSpellCheckerDictionary API to remove custom words in the dictionary. #​22039 (Also in 9)
  • Added session.serviceWorkerContext API to access basic service worker info and receive console logs from service workers. #​20624 (Also in 9)
  • Added a new force parameter to app.focus() on macOS to allow apps to forcefully take focus. #​22612 (Also in 8, 9)
  • Added ability to set and get title bar traffic light position on the fly (macOS). #​22533 (Also in 8, 9)
  • Added new spellcheck-dictionary-* events on the session module to help track and debug dictionary initialization. #​22449 (Also in 8, 9)
  • Added new worldSafeExecuteJavaScript webPreference to ensure that the return values from webFrame.executeJavaScript are world safe when context isolation is enabled. #​24711 (Also in 9)
  • Added support for property access to some getter/setter pairs on BrowserWindow. #​22771 (Also in 9)
  • Added support for suspend and resume events to Windows. #​24281 (Also in 8, 9)
  • Added support for suspend and resume events to macOS. #​24293 (Also in 8, 9)
  • Allow an optional callback parameter for WebFrame.executeJavaScript* methods, which is called synchronously unless the target context is paused. #​21423 (Also in 9)
  • EnableWebSQL is a new webpreference option to enable/disable websql api. #​23311 (Also in 7.2, 8, 9)
  • Expose sessionId associated with a target from debugger module. #​24397 (Also in 8, 9)
  • Implemented systemPreferences.getMediaAccessStatus() on Windows. #​24311 (Also in 8, 9)
  • Restored support for pdfium-based PDF viewer. #​21794 (Also in 9)
  • V8CacheOptions is a new webpreference option to enforce code caching policy. #​23867 (Also in 8, 9)
  • Ensured proper nativeImage serialization between renderer and browser processes via remote. #​23794 (Also in 7.3, 8, 9)
  • Improved error logging on moveItemToTrash failures on macOS. #​23589 (Also in 8, 9)

Fixes

  • Fixed BrowserWindow.moveAbove on Windows. #​23161
  • Fixed WebContents.focus not focusing window on macOS and Linux. #​22323
  • Fixed a crash that could happen when a warning was emitted when loading an extension. #​23667
  • Fixed a crash when closing GTK file open/save dialogs. #​23109
  • Fixed a crash when using <input type="file" />. #​22843
  • Fixed a potential crash when menu is created from an empty template. #​23308
  • Fixed an issue that could cause exceptions in the 'remote' module when accessing objects without constructors. #​22820
  • Fixed an issue where startDrag could crash if some specific strings were passed into nativeImage.createFromImage to create the icon. #​23467
  • Fixed an issue where diagnostic error reporting wasn't available in Node.js processes. #​23126
  • Fixed an issue where undo and redo shortcuts did not work in webviews. #​22911
  • Fixed crash when using client certificate. #​25019
  • Fixed issues with CORS when making requests from extensions. #​24822 (Also in 9)
  • Fixed loading shared worker scripts over custom protocol * fix crash when loading worker scripts with nodeIntegration enabled. #​24749 (Also in 9)
  • Accessing the screen module before the ready event no longer makes it impossible to access the screen module. #​22895 (Also in 8, 9)
  • Added missing support for isComposing KeyboardEvent property. #​23995 (Also in 8, 9)
  • Added workaround for nativeWindowOpen hang. #​22825 (Also in 8, 9)
  • DeviceId from navigator.mediaDevices.enumerateDevices is now consistent across reloads. #​22386 (Also in 8, 9)
  • Don't allow window to go behind menu bar on mac. #​22770 (Also in 9)
  • Don't ignore the referrer header in net.request. #​23386 (Also in 8, 9)
  • Enable NTLM v2 for POSIX platforms and added --disable-ntlm-v2 switch to disable it. #​23916 (Also in 7.3, 8, 9)
  • Enable offscreen rendering. #​22160 (Also in 8, 9)
  • Ensured that exit callbacks are run for Node.js in the renderer process. #​23419 (Also in 7.2, 8, 9)
  • Fix: Allow windows behind macOS elements if "frame" is false. #​24032 (Also in 9)
  • Fixed "Paste and Match Style" shortcut on macOS to match OS's "Option-Shift-Command-V". #​24182 (Also in 8, 9)
  • Fixed "null path-to-app" in test-app when Electron's path contains spaces or special characters. #​24230 (Also in 8, 9)
  • Fixed "will-navigate" event not being emitted for sandboxed contents. #​22188 (Also in 8, 9)
  • Fixed ARIA role="tree" for macOS VoiceOver. #​22367 (Also in 8, 9)
  • Fixed Electron apps getting rejected to Mac App Store. #​20965 (Also in 6.1, 8, 9)
  • Fixed GTK dark theme setting not respected in Electron on Linux. #​23711 (Also in 7.3, 8, 9)
  • Fixed Promise timeout issue when running Electron as Node. #​23153 (Also in 7.2, 9)
  • Fixed chrome://media-internals and chrome://webrtc-internals pages not loading. #​24057 (Also in 8, 9)
  • Fixed process.windowsStore returning undefined in AppX packages. #​23798 (Also in 7.3, 8, 9)
  • Fixed session.setSpellCheckerDictionaryDownloadURL to append the dictionary name at the end of requests instead of requesting the same URL for all dictionaries. #​22382 (Also in 8, 9)
  • Fixed webRequest API not working with WebSockets. #​22040 (Also in 8, 9)
  • Fixed webRequest module not working with file:// protocol. #​22903 (Also in 9)
  • Fixed webRequest not working for CORS requests. #​22407 (Also in 9)
  • Fixed win.setMenuBarVisibility(false) not hiding menu bar. #​23214 (Also in 9)
  • Fixed a bezeling issue on vibrant non-frameless BrowserWindows. #​23809 (Also in 9)
  • Fixed a crash in TouchBar for certain methods. #​23970
  • Fixed a crash in webContents.print() with custom print margins. #​22164 (Also in 8, 9)
  • Fixed a crash that could happen when attempting to access a session during shutdown. #​23039 (Also in 8, 9)
  • Fixed a crash that could happen when using hookWindowMessage on Windows. #​24768 (Also in 9)
  • Fixed a crash that could occur when sending arrays over IPC. #​22753 (Also in 8, 9)
  • Fixed a crash that could occur when using in-memory sessions. #​25001 (Also in 9)
  • Fixed a crash that could occur when using the ipcRenderer module after blink had released the context. Instead, a JS exception will be thrown. #​23977 (Also in 8, 9)
  • Fixed a crash which could occur during page navigations. #​23271 (Also in 8, 9)
  • Fixed a potential crash on devices which had not connected any printers to their network. #​22418 (Also in 8, 9)
  • Fixed a potential crash on invalid zoomFactor values when setting the zoom factor of a webpage. #​22673 (Also in 7.2, 8, 9)
  • Fixed a termination crash on Web Workers with Node.js integration enabled. #​24462 (Also in 8, 9)
  • Fixed a use-after-free error that could happen if a Tray was destroyed while showing a custom context menu. #​22842 (Also in 7.2, 8, 9)
  • Fixed an error when calling dialog.showCertificateTrustDialog with no BrowserWindow. #​24118 (Also in 7.3, 8, 9)
  • Fixed an intermittent high-CPU usage problem caused a system clock issue during sleep. #​24413 (Also in 8, 9)
  • Fixed an issue where TypeError occurred on initializing CrashReporter. #​22274 (Also in 8, 9)
  • Fixed an issue where VoiceOver was unable to navigate from the top-level window back into the web contents. #​24698 (Also in 9)
  • Fixed an issue where nativeImages might throw conversion errors in the renderer process. #​23543 (Also in 7.3, 8, 9)
  • Fixed an issue where rmdir and rmdirSync work with original-fs in an asar context. #​23951 (Also in 8, 9)
  • Fixed an issue where shutdown would be emitted both on app and system shutdown on macOS. #​24139 (Also in 8, 9)
  • Fixed an issue where undefined was printed from console.log on Window when no arguments were passed. #​22165 (Also in 8, 9)
  • Fixed an issue where webContents.print() would sometimes hang with invalid settings. #​24507 (Also in 9)
  • Fixed an issue where window.location properties would throw an error for windows opened with window.open. #​23804 (Also in 8, 9)
  • Fixed an issue where withFileTypes was not supported as an option to fs.readdir or fs.readdirSync under asar. #​24106 (Also in 8, 9)
  • Fixed an issue where changing theme on macOS would break window maximizability state. #​22677 (Also in 9)
  • Fixed an issue where cpu and heap profiling in Node.js did not work properly with --cpu-prof, --heap-prof, and related CLI flags. #​24540 (Also in 8, 9)
  • Fixed an issue where frameless modal windows with a vibrancy setting had bezeled corners. #​24284 (Also in 9)
  • Fixed an issue where macOS window vibrancy active state did not always match the active state of the window. #​24532 (Also in 8, 9)
  • Fixed an issue where native macOS dialogs sometimes failed to show after modal close. #​22858 (Also in 8, 9)
  • Fixed an issue where some Node.js methods would not work with URL instances constructed in the renderer process. #​24860 (Also in 8, 9)
  • Fixed an issue where some logging would double-print. #​22342 (Also in 8, 9)
  • Fixed an issue where some old notifications were not properly removed from the Notification Center on macOS. #​24404 (Also in 8, 9)
  • Fixed an issue where suspend/resume were emitted twice on macOS. #​24843 (Also in 8, 9)
  • Fixed an issue where the 'about' role had on effect on Windows menus. #​23717 (Also in 7.3, 8, 9)
  • Fixed an issue where the Save button did not function in PDF previews. #​24995 (Also in 9)
  • Fixed an issue whereby macOS would fail to allow file extensions containing periods. #​23409 (Also in 7.2, 8, 9)
  • Fixed an issue which would cause streaming protocol responses to stall in some cases. #​24081 (Also in 8, 9)
  • Fixed an issue with maximizable state persistence of BrowserWindows on macOS. #​22988 (Also in 7.2, 8, 9)
  • Fixed an issue with navigator.languages and Accept-Language did not fully respect users' language preferences on Windows and macOS. This also improved fallback font selection for CJK texts on Windows. #​23247 (Also in 7.2, 8, 9)
  • Fixed an issue with safeDialog preferences not being passed properly. #​22353 (Also in 8)
  • Fixed an issue with click events not being emitted on macOS for Trays with context menus set. #​24235 (Also in 8, 9)
  • Fixed an issue with possible creation of a messageBox which cannot be dismissed on macOS. #​22672 (Also in 7.2, 8, 9)
  • Fixed an issue with volume-related globalShortcut registration. #​23823 (Also in 8, 9)
  • Fixed an occasional crash when closing all BrowserWindows. #​22948 (Also in 7.2, 8, 9)
  • Fixed an occasional menu crash on macOS Catalina when menu is closing. #​23806 (Also in 8, 9)
  • Fixed an occasional segfault with modal windows being closed or destroyed. #​22410 (Also in 8, 9)
  • Fixed broken --trace-sync-io flag in Node.js. #​24544 (Also in 8, 9)
  • Fixed broken use of contextCodeGeneration parameter to Node.js' script.runInNewContext(). #​23129 (Also in 8, 9)
  • Fixed bug on macOS where the main window could be targeted for a focus event when it was disabled behind a modal. #​24352 (Also in 8, 9)
  • Fixed bug that occurred when using trafficLightPosition API in RTL mode. #​22132 (Also in 8, 9)
  • Fixed clipboard.readBuffer returning incorrect value. #​24467 (Also in 8, 9)
  • Fixed crash in network service process when using protocol.registerSchemeAsPrivileged api. #​22867 (Also in 9)
  • Fixed crash that could occur when calling session.fromPartition inside the ready event. #​22772 (Also in 9)
  • Fixed crash when navigating between origins in a child window with nativeWindowOpen and contextIsolation enabled. #​23896 (Also in 8, 9)
  • Fixed crash when navigating from a page with webview that has inherited zoom level. #​24763 (Also in 8, 9)
  • Fixed crash with webview during some window management events like resize, scroll etc. #​23342 (Also in 7.2, 8, 9)
  • Fixed crash-on-exit that could happen during node platform deinitialization. #​23116
  • Fixed delayed execution of some Node.js callbacks in the main process. #​24174 (Also in 8, 9)
  • Fixed disabling color correct rendering with --disable-color-correct-rendering. #​23899 (Also in 8, 9)
  • Fixed flash plugin not working. #​22072 (Also in 8, 9)
  • Fixed inactive windows having active titlebar on Windows. #​24874 (Also in 8, 9)
  • Fixed incorrect hit testing on top of ::after element with layoutNG. #​23179 (Also in 9)
  • Fixed issue where SameSite cookies would not be attached to outgoing requests from the net module. #​22788
  • Fixed issue where prefers-color-scheme would not be updated / set correctly when your OS was in dark mode. #​22896 (Also in 8, 9)
  • Fixed issue where dictionary files for the spellchecker would be downloaded to the app install directory instead of the user data directory. #​22444 (Also in 8, 9)
  • Fixed issue where mutating the global Object prototype could cause internal Electron logic to throw errors. #​22616 (Also in 8, 9)
  • Fixed issue where navigating with the mouse buttons 4/5 would result in full page loads instead of in-page popstate navigations. #​22202 (Also in 8, 9)
  • Fixed issue where renderers could crash during GC when using the contextBridge module. #​22056 (Also in 8, 9)
  • Fixed issue where repositioned traffic lights would be in the wrong position after the user switches OS theme. #​22534 (Also in 8, 9)
  • Fixed issued where voice over would not read words as you typed them. #​24838
  • Fixed memory leak when using contextBridge with sandbox=true. #​23207 (Also in 7.2, 8, 9)
  • Fixed memory leaks in sandbox mode when using contextBridge with promises or ipcRenderer.invoke. #​23321 (Also in 8, 9)
  • Fixed missing guid parameter in Linux crash reports. #​24897 (Also in 9)
  • Fixed missing debug symbols for crashpad handler on macOS. #​23537 (Also in 9)
  • Fixed no session in webContents of type remote. #​24064 (Also in 9)
  • Fixed occasional WebFrame crashes caused by removed iframes. #​22925 (Also in 8, 9)
  • Fixed possible freeze on window with disabled background throttling. #​22832 (Also in 9)
  • Fixed potentially invalid duplex mode settings on Linux. #​24527 (Also in 9)
  • Fixed several memory leaks related to V8 handles not being properly scoped. #​22531
  • Fixed some Wasm and diagnostics issues in main and renderer process execution of Node.js. #​23261
  • Fixed some event listener crashes in Tray. #​23140
  • Fixed some properties not working in webview tags. #​22485 (Also in 8, 9)
  • Fixed the JavaScript object of BrowserWindow not garbage collected when window is closed. #​22006
  • Fixed the acceptLanguages argument being ignored in session.setUserAgent(). #​23961 (Also in 7.3, 8, 9)
  • Fixed the print button functionality in the PDF viewer extension. #​22760 (Also in 9)
  • Fixed tray menu on Windows not keyboard navigable. #​23879 (Also in 8, 9)
  • Fixed tray menu showing in taskbar on Windows. #​24192 (Also in 8, 9)
  • Fixed window titlebar not responding to pen on Windows 10. #​24102 (Also in 7.3, 8, 9)
  • Fixed: On some Windows machines, especially Windows Insider builds, Electron would crash silently during startup. #​24038 (Also in 9)
  • Increased maximum length for crash keys from 127B to 20KB. #​24853 (Also in 9)
  • Limited manipulation of custom spellchecker dictionary words to persistent sessions. #​22157 (Also in 9)
  • MacOS VoiceOver is now able to find its way back into web contents after it navigated "out" of an application. #​22399 (Also in 7.2, 8, 9)
  • Protocol response streams are now destroyed if the request is aborted. [#​24656](htt
  • Renovate configuration

    πŸ“… Schedule: "before 3am on the first day of the month" in timezone America/New_York.

    🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

    ♻️ Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

    πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


    • If you want to rebase/retry this PR, check this box

    This PR has been generated by WhiteSource Renovate. View repository job log here.

    @renovate renovate bot added renovate Triggered by renovatebot type: dependencies labels Aug 25, 2020
    @cypress-bot
    Copy link
    Contributor

    cypress-bot bot commented Aug 25, 2020

    See the guidelines for reviewing dependency updates for info on how to review dependency update PRs.

    @cypress
    Copy link

    cypress bot commented Aug 25, 2020



    Test summary

    8565 β€’ 0 β€’ 124 β€’ 3


    Run details

    Project cypress
    Status Passed
    Commit 4da8d18
    Started Sep 29, 2020 5:37 PM
    Ended Sep 29, 2020 5:48 PM
    Duration 11:08 πŸ’‘
    OS Linux Debian - 10.2
    Browser Multiple

    View run in Cypress Dashboard ➑️


    This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

    @renovate renovate bot changed the title chore(deps): update dependency electron to version .x 🌟 chore(deps): update dependency electron to version .x 🌟 Sep 1, 2020
    @renovate renovate bot changed the title chore(deps): update dependency electron to version .x 🌟 chore(deps): update dependency electron to version .x 🌟 Sep 1, 2020
    @flotwig flotwig changed the title chore(deps): update dependency electron to version .x 🌟 feat(deps): update dependency electron to version 10.1.0 🌟 Sep 1, 2020
    @flotwig
    Copy link
    Contributor

    flotwig commented Sep 1, 2020

    Having some trouble with these illegal access errors, haven't been able to find a cause, opened an issue on the electron repo: electron/electron#25267

    @jennifer-shehane
    Copy link
    Member

    @flotwig It seems Electron released a fix for this blocking bug.

    @flotwig
    Copy link
    Contributor

    flotwig commented Sep 28, 2020

    Just waiting for a new 10.x release (or for 11.x to become stable, ig) with the fix now

    @renovate renovate bot changed the title feat(deps): update dependency electron to version 10.1.0 🌟 chore(deps): update dependency electron to version .x 🌟 Sep 29, 2020
    @flotwig flotwig changed the title chore(deps): update dependency electron to version .x 🌟 feat(deps): update dependency electron to version 10.1.3 🌟 Sep 29, 2020
    node 12.16.3 removed `--http-parser=legacy`, but now we have `insecureHTTPParser` available on `ClientRequest`, which does the same thing but with `llhttp`
    @renovate renovate bot changed the title feat(deps): update dependency electron to version 10.1.3 🌟 feat(deps): update dependency electron to version 10.1.3 🌟 Sep 29, 2020
    Copy link
    Contributor

    @flotwig flotwig left a comment

    Choose a reason for hiding this comment

    The reason will be displayed to describe this comment to others. Learn more.

    works fine after updating HTTP parser fix

    @cypress-bot
    Copy link
    Contributor

    cypress-bot bot commented Oct 14, 2020

    Released in 5.4.0.

    This comment thread has been locked. If you are still experiencing this issue after upgrading to
    Cypress v5.4.0, please open a new issue.

    @cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 14, 2020
    @renovate renovate bot deleted the renovate/electron-10.x branch October 15, 2020 06:44
    Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
    Labels
    renovate Triggered by renovatebot type: dependencies
    Projects
    None yet
    Development

    Successfully merging this pull request may close these issues.

    chromeWebSecurity setting does not take effect in Electron browser
    3 participants