Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(driver): hide forced GC warning if using FF >= 80 #8725

Merged
merged 1 commit into from Oct 2, 2020

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Oct 1, 2020

  • Closes

User facing changelog

Fixed an issue where the forced garbage collection timer would still display in Firefox, even when using a version of Firefox newer than 80.

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • [na] Has a PR for user-facing changes been opened in cypress-documentation?
  • [na] Have API changes been updated in the type definitions?
  • [na] Have new configuration options been added to the cypress.schema.json?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 1, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Oct 1, 2020



Test summary

3827 3 55 1


Run details

Project cypress
Status Failed
Commit 033462b
Started Oct 1, 2020 10:14 PM
Ended Oct 1, 2020 10:25 PM
Duration 11:03 💡
OS Linux Debian - 10.2
Browser Firefox 77

View run in Cypress Dashboard ➡️


Failures

cypress/integration/commands/net_stubbing_spec.ts Failed
1 network stubbing > intercepting request > can reply with a JSON fixture
2 network stubbing > waiting and aliasing > can timeout incrementally waiting on requests
3 network stubbing > waiting and aliasing > can alias a route without stubbing it

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@flotwig flotwig requested review from chrisbreiding and jennifer-shehane and removed request for jennifer-shehane October 1, 2020 21:38
@chrisbreiding
Copy link
Contributor

In what circumstances would the timer still appear? How would I reproduce the issue?

@flotwig
Copy link
Contributor Author

flotwig commented Oct 2, 2020

Try FF 80 in open mode. The timer should be hidden in this PR and visible in develop. In FF79 it should be visible in both.

@flotwig flotwig merged commit 8056986 into develop Oct 2, 2020
@muzahir-12
Copy link

muzahir-12 commented Oct 2, 2020 via email

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 14, 2020

Released in 5.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 14, 2020
@flotwig flotwig deleted the remove-ff-gcinterval-warning branch January 24, 2022 18:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants