fix: prevent cy.route2 callback timeouts from leaking into next test

[flotwig]

• Closes

User facing changelog

• Fixed a bug in cy.route2 where route handler timeouts could leak into other tests and cause random failures.

Additional details

• this was a major source of flake in the net-stubbing tests - timeouts for the req/res callbacks could leak between tests, and not all of the tests were designed to resolve within defaultCommandTimeout
• this is why there were random clusters of tests that would be flakier than others!
• additionally addressed a few other flaky tests
• added retries to one flaky test which i am unable to reproduce locally despite running many many times

How has the user experience changed?

PR Tasks

• Have tests been added/updated?
• Has the original issue been tagged with a release in ZenHub?
• [na] Has a PR for user-facing changes been opened in cypress-documentation?
• [na] Have API changes been updated in the type definitions?
• [na] Have new configuration options been added to the cypress.schema.json?

[cypress-bot]

Thanks for taking the time to open a PR!

• Create a Draft Pull Request if your PR is not ready for review. Mark the PR as Ready for Review when you're ready for a Cypress team member to review the PR.
• Become familiar with the Code Review Checklist for guidelines on coding standards and what needs to be done before a PR can be merged.

[cypress]

---

Test summary

3817 • 0 • 55 • 1

---

Run details

Project	cypress
Status	Passed
Commit	b47a040
Started	Oct 1, 2020 9:53 PM
Ended	Oct 1, 2020 10:03 PM
Duration	10:39 💡
OS	Linux Debian - 10.2
Browser	Firefox 77

View run in Cypress Dashboard ➡️

---

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

[JessicaSachs]

This seems straightforward to me.

I'm curious if Cypress.state('test') ever changes when it's not the same test -- e.g. with property modifications such that you can't === to check identity.

I'm also curious why you removed the .should('be.visible') check. Because it was flaking?

[flotwig]

Yeah, I'm not sure why the be.visible check was failing, but changing it to just cy.contains eliminated the flake.

[cypress-bot]

Released in 5.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.4.0, please open a new issue.