Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: dashboard banner z-index #8745

Conversation

marcosrjjunior
Copy link
Contributor

@marcosrjjunior marcosrjjunior commented Oct 3, 2020

  • Closes

User facing changelog

The browser dropdown is no longer covered when opened from the Runs tab in the Test Runner.

Additional details

small style changes to desktop-gui

How has the user experience changed?

Before
zindex

After
zindex1

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 3, 2020

Thanks for taking the time to open a PR!

@marcosrjjunior marcosrjjunior changed the title style:dashboard banner z-index style: dashboard banner z-index Oct 3, 2020
Copy link
Member

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! I added an integration and visual test to check for this in the future.

@jennifer-shehane jennifer-shehane merged commit 1f8c79f into cypress-io:develop Oct 7, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 14, 2020

Released in 5.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 14, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants