Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add notification in Desktop GUI when there is a new version available #8803

merged 10 commits into from Oct 13, 2020


Copy link

User facing changelog

  • Replaced the Update Available banner with a dismiss-able notification. The notification will not re-appear for the same version and will only re-appear when there is a newer version available.

How has the user experience changed?

Screen Shot 2020-10-09 at 11 05 51 AM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

Copy link

cypress-bot bot commented Oct 9, 2020

Thanks for taking the time to open a PR!

Copy link

cypress bot commented Oct 9, 2020

Test summary

8614 0 124 3

Run details

Project cypress
Status Passed
Commit c28ce40
Started Oct 13, 2020 1:37 PM
Ended Oct 13, 2020 1:48 PM
Duration 11:11 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

CypressAdam previously approved these changes Oct 9, 2020
Copy link

@CypressAdam CypressAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Had a look at them tests IRL. LGTM

// disable livereload within the Cypress-loaded desktop GUI. it doesn't fully
// reload the app because the stubbed out ipc calls don't work after the first
// time, so it ends up a useful white page
cy.route2({ path: /livereload/ }, '')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


Copy link

@chrisbreiding There's a test that seems to be consistently failing now in desktop-gui. Not sure how it's related to this PR exactly.

@chrisbreiding chrisbreiding merged commit 4db37e9 into develop Oct 13, 2020
Copy link

cypress-bot bot commented Oct 14, 2020

Released in 5.4.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.4.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 14, 2020
@chrisbreiding chrisbreiding deleted the TR-354-update-toast branch April 5, 2022 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants