feat: Add notification in Desktop GUI when there is a new version available #8803
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
Test summary
Run details
View run in Cypress Dashboard ➡️ This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard |
CypressAdam
previously approved these changes
Oct 9, 2020
jennifer-shehane
previously approved these changes
Oct 13, 2020
| // disable livereload within the Cypress-loaded desktop GUI. it doesn't fully | ||
| // reload the app because the stubbed out ipc calls don't work after the first | ||
| // time, so it ends up a useful white page | ||
| cy.route2({ path: /livereload/ }, '') |
|
@chrisbreiding There's a test that seems to be consistently failing now in desktop-gui. Not sure how it's related to this PR exactly. |
chrisbreiding
dismissed stale reviews from jennifer-shehane and CypressAdam
via
31aaa17
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User facing changelog
How has the user experience changed?
PR Tasks
cypress-documentation?type definitions?cypress.schema.json?