Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: route all https traffic through proxy #8827

Merged
merged 10 commits into from Oct 20, 2020
Merged

Conversation

kuceb
Copy link
Contributor

@kuceb kuceb commented Oct 13, 2020

TR-416

pass all https through our proxy routes instead of making direct connections

  • needed for cy.sessions work for injected page setters for localStorage, and detecting domains which served html

User facing changelog

TBD

Additional details

How has the user experience changed?

PR Tasks

  • ensure partial injection (document.domain) only affects aut domain
  • @flotwig should we add tests for and tag as closed the issues this may fix related to cy.route2?
  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 13, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Oct 14, 2020



Test summary

8614 0 124 3Flakiness 1


Run details

Project cypress
Status Passed
Commit b0ee908
Started Oct 19, 2020 5:45 PM
Ended Oct 19, 2020 5:57 PM
Duration 11:46 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

@kuceb kuceb changed the title Route all https traffic through proxy fix: route all https traffic through proxy Oct 16, 2020
@kuceb kuceb marked this pull request as ready for review October 19, 2020 14:50
@kuceb kuceb requested a review from flotwig October 19, 2020 21:32
@kuceb
Copy link
Contributor Author

kuceb commented Oct 19, 2020

@flotwig should we add tests for and tag as closed the issues this may fix related to cy.route2?

Copy link
Contributor

@flotwig flotwig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is quite a beautiful change. very very nice!!!

@flotwig
Copy link
Contributor

flotwig commented Oct 19, 2020

@flotwig should we add tests for and tag as closed the issues this may fix related to cy.route2?

I'm not aware of any open issues that this fixes for cy.route2, we knew that there was an issue with breaking existing HTTPS connections but AFAIK no issues have been opened 🤷

@flotwig
Copy link
Contributor

flotwig commented Oct 20, 2020

Oh, actually, possibly #8815 is bein caused by this...

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Oct 27, 2020

Released in 5.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants