Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(types): fix typedefs for retries config #8869

merged 2 commits into from Oct 19, 2020


Copy link

@kuceb kuceb commented Oct 16, 2020

previously typedefs required you to specify both openMode and runMode, but it's easier to just exclude one or the other e.g:
retries: { runMode: 2 }

  • Closes TBD

User facing changelog

update type definitions for retries config

Additional details

How has the user experience changed?

PR Tasks

  • Have tests been added/updated?
  • Has the original issue been tagged with a release in ZenHub?
  • Has a PR for user-facing changes been opened in cypress-documentation?
  • Have API changes been updated in the type definitions?
  • Have new configuration options been added to the cypress.schema.json?

Copy link

cypress-bot bot commented Oct 16, 2020

Thanks for taking the time to open a PR!

Copy link

cypress bot commented Oct 16, 2020

Test summary

3843 0 55 1

Run details

Project cypress
Status Passed
Commit bba822c
Started Oct 19, 2020 5:51 AM
Ended Oct 19, 2020 6:04 AM
Duration 13:18 💡
OS Linux Debian - 10.2
Browser Firefox 77

View run in Cypress Dashboard ➡️

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link

@jennifer-shehane jennifer-shehane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool, didn't know this. I verified this actually does work as documented in types.

@jennifer-shehane jennifer-shehane merged commit 7d658ad into develop Oct 19, 2020
60 checks passed
Copy link

cypress-bot bot commented Oct 27, 2020

Released in 5.5.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.5.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Oct 27, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

2 participants