Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add release notes modal #9006

merged 7 commits into from Nov 2, 2020


Copy link

User facing changelog

  • We now show a modal with release notes when there is a new version of Cypress.

Additional details

When a new version is released and associated release notes are available, clicking 'Learn more' in the update notice shows the release notes.

The functionality relies on a release of cypress-on, but can be released without it as it falls back to previous behavior if cypress-on does not return the release notes.

How has the user experience changed?

The update notice 'Learn more' used to go directly to the update instructions. It will still do so if the new version has no release notes. But if there are release notes, it will show them in the modal before clicking 'Update Now' shows the update instructions.

Screen Shot 2020-10-28 at 10 20 30 AM

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?
  • N/A Has a PR for user-facing changes been opened in cypress-documentation?
  • N/A Have API changes been updated in the type definitions?
  • N/A Have new configuration options been added to the cypress.schema.json?

Copy link

cypress-bot bot commented Oct 28, 2020

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding changed the title Add release notes modal feat (desktop-gui): Add release notes modal Oct 28, 2020
@chrisbreiding chrisbreiding changed the title feat (desktop-gui): Add release notes modal feat: Add release notes modal Oct 28, 2020
Copy link

cypress bot commented Oct 28, 2020

Test summary

8657 0 124 3Flakiness 1

Run details

Project cypress
Status Passed
Commit ec9e8d3
Started Oct 30, 2020 7:38 PM
Ended Oct 30, 2020 7:50 PM
Duration 12:15 💡
OS Linux Debian - 10.2
Browser Multiple

View run in Cypress Dashboard ➡️


cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

Copy link

@CypressAdam CypressAdam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we keep the kitten full time?

edit: i hit the wrong radio and pressed the right button 😞

CypressAdam previously approved these changes Oct 28, 2020
@jennifer-shehane jennifer-shehane merged commit 757ddc8 into develop Nov 2, 2020
62 checks passed
Copy link

cypress-bot bot commented Nov 9, 2020

Released in 5.6.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v5.6.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Nov 9, 2020
@chrisbreiding chrisbreiding deleted the TR-357-release-notes-modal branch April 5, 2022 18:27
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
None yet
None yet

Successfully merging this pull request may close these issues.

None yet

3 participants