fix(route2): fixed the issue with not being able to await a request body when providing static response stub #9059
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for taking the time to open a PR!
|
|
|
Andarist
commented
Nov 2, 2020
|
|
||
| return sendStaticResponse(request.res, route.staticResponse, request.onResponse!) | ||
| } | ||
|
|
||
| const ensureBody = (cb: () => void) => { |
There was a problem hiding this comment.
right now every branch of the code that follows this declaration is using both ensureBody & emitReceived, so maybe you'd like to have this refactored somehow? If yes - let me know if you have anything in particular in mind. A change is not needed that much as the code is readable but maybe it would be good to ensure that both of those things will always be called for this logic rather if some new branches get added?
Andarist
changed the title
…iding static response stub
Andarist
force-pushed
the
fix/await-request-body-static-response-stub
branch
from
0baf436
to
f28c601
Compare
|
Released in This comment thread has been locked. If you are still experiencing this issue after upgrading to |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
User facing changelog
Fixed an issue with not being able to await a request body when providing static response stub and using the
experimentalNetworkStubbing.Additional details
It's a bug fix.
experimentalNetworkStubbing
How has the user experience changed?
N/A
PR Tasks