Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(types): have cy.wait(alias) yield new Request type #9266

Merged
merged 6 commits into from Nov 23, 2020
Merged

Conversation

flotwig
Copy link
Contributor

@flotwig flotwig commented Nov 20, 2020

User facing changelog

  • Updated the type yielded by cy.wait(alias) to the cy.http Request type. This is a breaking types change, previously, it yielded Cypress.WaitXHR. For more information, please see the migration guide.

Additional details

How has the user experience changed?

PR Tasks

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 20, 2020

Thanks for taking the time to open a PR!

@cypress
Copy link

cypress bot commented Nov 20, 2020



Test summary

8740 0 118 3Flakiness 1


Run details

Project cypress
Status Passed
Commit cbca7b3
Started Nov 23, 2020 5:11 PM
Ended Nov 23, 2020 5:23 PM
Duration 12:05 💡
OS Linux Debian - 10.5
Browser Multiple

View run in Cypress Dashboard ➡️


Flakiness

cypress/integration/retries.ui.spec.js Flakiness
1 runner/cypress retries.ui.spec > opens attempt on each attempt failure for the screenshot, and closes after test passes

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Dashboard

packages/net-stubbing/lib/external-types.ts Outdated Show resolved Hide resolved
packages/net-stubbing/lib/external-types.ts Outdated Show resolved Hide resolved
flotwig and others added 3 commits November 23, 2020 11:45
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
Co-authored-by: Jennifer Shehane <jennifer@cypress.io>
jennifer-shehane
jennifer-shehane previously approved these changes Nov 23, 2020
@flotwig flotwig merged commit 0d5b932 into develop Nov 23, 2020
57 of 62 checks passed
@flotwig flotwig deleted the issue-8731 branch January 24, 2022 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cy.wait types for yielded object are incorrect when awaiting cy.route2 routes
2 participants