Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add EventEmitter type to FileObject #9276

Merged
merged 5 commits into from Dec 16, 2020

Conversation

sainthkh
Copy link
Contributor

@sainthkh sainthkh commented Nov 23, 2020

User facing changelog

  • Updated the FileObject type for the file argument of the file:preprocessor event to include the EventEmitter type.

Additional details

  • Why was this change necessary? => EventEmitter type was missing. It causes false type errors in TypeScript files.
  • What is affected by this change? => N/A
  • Any implementation details to explain? => I checked the type from here.

fileObject = (fileObjects[filePath] = _.extend(new EE(), {
filePath,
shouldWatch,
outputPath: appData.getBundledFilePath(config.projectRoot, baseFilePath),
}))

How has the user experience changed?

N/A

PR Tasks

  • Have tests been added/updated?
  • Has the original issue or this PR been tagged with a release in ZenHub?

@cypress-bot
Copy link
Contributor

cypress-bot bot commented Nov 23, 2020

Thanks for taking the time to open a PR!

@chrisbreiding chrisbreiding merged commit 4ef189e into cypress-io:develop Dec 16, 2020
@cypress-bot
Copy link
Contributor

cypress-bot bot commented Dec 21, 2020

Released in 6.2.0.

This comment thread has been locked. If you are still experiencing this issue after upgrading to
Cypress v6.2.0, please open a new issue.

@cypress-bot cypress-bot bot locked as resolved and limited conversation to collaborators Dec 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileObject type should extend EventEmitter
3 participants