From ad396fb25f3988a417f4acf83fc3e9ae457aea43 Mon Sep 17 00:00:00 2001 From: Matt Schile Date: Fri, 28 Apr 2023 09:10:48 -0600 Subject: [PATCH] Apply suggestions from code review --- lib/rules/no-unnecessary-waiting.js | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/lib/rules/no-unnecessary-waiting.js b/lib/rules/no-unnecessary-waiting.js index 860262a6..53a8606f 100644 --- a/lib/rules/no-unnecessary-waiting.js +++ b/lib/rules/no-unnecessary-waiting.js @@ -60,7 +60,6 @@ function isIdentifierNumberConstArgument (node, scope) { const resolvedIdentifier = scope.references.find((ref) => ref.identifier === identifier).resolved const definition = resolvedIdentifier.defs[0] const isVariable = definition.type === 'Variable' - const isImportBinding = definition.type === 'ImportBinding' // const amount = 1000 or const amount = '@alias' // cy.wait(amount) @@ -73,9 +72,7 @@ function isIdentifierNumberConstArgument (node, scope) { // import { WAIT } from './constants' // cy.wait(WAIT) // we don't know if WAIT is a number or alias '@someRequest', so don't fail - if (isImportBinding) { - return false - } + if (definition.type === 'ImportBinding') return false const param = definition.node.params[definition.index]