From 7fcb80912a2f0992f3fd8001274a8ee2148631a1 Mon Sep 17 00:00:00 2001 From: paulj Date: Fri, 2 Dec 2022 16:10:23 -0500 Subject: [PATCH 1/4] update action vesrions to latest --- .github/workflows/example-firefox.yml | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/.github/workflows/example-firefox.yml b/.github/workflows/example-firefox.yml index 68960fee0..28b77fdd7 100644 --- a/.github/workflows/example-firefox.yml +++ b/.github/workflows/example-firefox.yml @@ -11,10 +11,10 @@ jobs: firefox: # should include Firefox browser install # https://github.com/actions/virtual-environments - runs-on: ubuntu-18.04 + runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Firefox uses: ./ @@ -26,7 +26,7 @@ jobs: browser: firefox # report screenshot size and store the screenshots as test artifacts - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v3 with: name: screenshots-in-firefox path: examples/firefox/cypress/screenshots @@ -39,10 +39,10 @@ jobs: firefox-v10: # should include Firefox browser install # https://github.com/actions/virtual-environments - runs-on: ubuntu-18.04 + runs-on: ubuntu-latest steps: - name: Checkout - uses: actions/checkout@v2 + uses: actions/checkout@v3 - name: Firefox uses: ./ @@ -54,7 +54,7 @@ jobs: browser: firefox # report screenshot size and store the screenshots as test artifacts - - uses: actions/upload-artifact@v2 + - uses: actions/upload-artifact@v3 with: name: screenshots-in-firefox path: examples/v10/firefox/cypress/screenshots From 5651641d71632ca89f5c9053ec47da0eb53ba559 Mon Sep 17 00:00:00 2001 From: paulj Date: Fri, 2 Dec 2022 16:21:23 -0500 Subject: [PATCH 2/4] install cypress@10.0.0 not the removed binary --- .github/workflows/example-install-only.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/example-install-only.yml b/.github/workflows/example-install-only.yml index cb6bacda1..4f0f8a74e 100644 --- a/.github/workflows/example-install-only.yml +++ b/.github/workflows/example-install-only.yml @@ -61,7 +61,7 @@ jobs: key: my-cache-${{ runner.os }}-${{ hashFiles('package-lock.json') }} - name: Install Cypress 📥 - run: npm i https://cdn.cypress.io/beta/npm/10.0.0/linux-x64/10.0-release-04e5d70d48a1337b702f53ac9677350167eb7ae6/cypress.tgz + run: npm i cypress@10.0.0 - name: Cypress tests 🧪 uses: ./ From aa461df96c069534fa55caaea89fbe711a3f6c2e Mon Sep 17 00:00:00 2001 From: paulj Date: Fri, 2 Dec 2022 16:49:14 -0500 Subject: [PATCH 3/4] update package.lock to include typescript@3.9.10 --- examples/v10/react-scripts/package-lock.json | 21 ++++++++++++++++++++ examples/v9/react-scripts/package-lock.json | 21 ++++++++++++++++++++ 2 files changed, 42 insertions(+) diff --git a/examples/v10/react-scripts/package-lock.json b/examples/v10/react-scripts/package-lock.json index 6731ddace..992f11c81 100644 --- a/examples/v10/react-scripts/package-lock.json +++ b/examples/v10/react-scripts/package-lock.json @@ -18168,6 +18168,20 @@ "integrity": "sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=", "dev": true }, + "node_modules/typescript": { + "version": "3.9.10", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.10.tgz", + "integrity": "sha512-w6fIxVE/H1PkLKcCPsFqKE7Kv7QUwhU8qQY2MueZXWx5cPZdwFupLgKK3vntcK98BtNHZtAF4LA/yl2a7k8R6Q==", + "dev": true, + "peer": true, + "bin": { + "tsc": "bin/tsc", + "tsserver": "bin/tsserver" + }, + "engines": { + "node": ">=4.2.0" + } + }, "node_modules/unicode-canonical-property-names-ecmascript": { "version": "1.0.4", "resolved": "https://registry.npmjs.org/unicode-canonical-property-names-ecmascript/-/unicode-canonical-property-names-ecmascript-1.0.4.tgz", @@ -34507,6 +34521,13 @@ "integrity": "sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=", "dev": true }, + "typescript": { + "version": "3.9.10", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.10.tgz", + "integrity": "sha512-w6fIxVE/H1PkLKcCPsFqKE7Kv7QUwhU8qQY2MueZXWx5cPZdwFupLgKK3vntcK98BtNHZtAF4LA/yl2a7k8R6Q==", + "dev": true, + "peer": true + }, "unicode-canonical-property-names-ecmascript": { "version": "1.0.4", "resolved": "https://registry.npmjs.org/unicode-canonical-property-names-ecmascript/-/unicode-canonical-property-names-ecmascript-1.0.4.tgz", diff --git a/examples/v9/react-scripts/package-lock.json b/examples/v9/react-scripts/package-lock.json index 7c9e7d056..cc8845869 100644 --- a/examples/v9/react-scripts/package-lock.json +++ b/examples/v9/react-scripts/package-lock.json @@ -18168,6 +18168,20 @@ "integrity": "sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=", "dev": true }, + "node_modules/typescript": { + "version": "3.9.10", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.10.tgz", + "integrity": "sha512-w6fIxVE/H1PkLKcCPsFqKE7Kv7QUwhU8qQY2MueZXWx5cPZdwFupLgKK3vntcK98BtNHZtAF4LA/yl2a7k8R6Q==", + "dev": true, + "peer": true, + "bin": { + "tsc": "bin/tsc", + "tsserver": "bin/tsserver" + }, + "engines": { + "node": ">=4.2.0" + } + }, "node_modules/unicode-canonical-property-names-ecmascript": { "version": "1.0.4", "resolved": "https://registry.npmjs.org/unicode-canonical-property-names-ecmascript/-/unicode-canonical-property-names-ecmascript-1.0.4.tgz", @@ -34507,6 +34521,13 @@ "integrity": "sha1-hnrHTjhkGHsdPUfZlqeOxciDB3c=", "dev": true }, + "typescript": { + "version": "3.9.10", + "resolved": "https://registry.npmjs.org/typescript/-/typescript-3.9.10.tgz", + "integrity": "sha512-w6fIxVE/H1PkLKcCPsFqKE7Kv7QUwhU8qQY2MueZXWx5cPZdwFupLgKK3vntcK98BtNHZtAF4LA/yl2a7k8R6Q==", + "dev": true, + "peer": true + }, "unicode-canonical-property-names-ecmascript": { "version": "1.0.4", "resolved": "https://registry.npmjs.org/unicode-canonical-property-names-ecmascript/-/unicode-canonical-property-names-ecmascript-1.0.4.tgz", From 02314224b5d00710b3dd22cbd19ab82b9baba03f Mon Sep 17 00:00:00 2001 From: Paul Jaffre Date: Wed, 7 Dec 2022 15:03:57 -0500 Subject: [PATCH 4/4] pin ubuntu to 20.04 for consistency --- .github/workflows/example-firefox.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/example-firefox.yml b/.github/workflows/example-firefox.yml index 28b77fdd7..cbc20488d 100644 --- a/.github/workflows/example-firefox.yml +++ b/.github/workflows/example-firefox.yml @@ -11,7 +11,7 @@ jobs: firefox: # should include Firefox browser install # https://github.com/actions/virtual-environments - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - name: Checkout uses: actions/checkout@v3 @@ -39,7 +39,7 @@ jobs: firefox-v10: # should include Firefox browser install # https://github.com/actions/virtual-environments - runs-on: ubuntu-latest + runs-on: ubuntu-20.04 steps: - name: Checkout uses: actions/checkout@v3