Add config options for OAuth callback hostname and port (CEA-122) - #69
Merged
Conversation
- Add OAUTH_CALLBACK_HOSTNAME environment variable (defaults to 'localhost') - Add OAUTH_CALLBACK_PORT environment variable (defaults to '3457') - Update all hardcoded localhost:3457 references to use these config options - Fixes issue where OAuth callback URL was hardcoded and couldn't be customized for different environments 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Replace OAUTH_CALLBACK_HOSTNAME and OAUTH_CALLBACK_PORT with single OAUTH_CALLBACK_BASE_URL - Defaults to 'http://localhost:3457' (maintains backward compatibility) - Users can now set complete base URLs without assuming port format: - OAUTH_CALLBACK_BASE_URL=https://my-domain.com - OAUTH_CALLBACK_BASE_URL=http://my-host:8080 - OAUTH_CALLBACK_BASE_URL=http://localhost:3457 (default) - Updated all OAuth URL construction, console output, and HTML templates 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Document new OAUTH_CALLBACK_BASE_URL environment variable - Note support for configurable OAuth callback URLs for different deployment environments 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Connoropolous
approved these changes
Jun 25, 2025
- Reference PR #69 in changelog for OAuth callback configuration feature 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
|
@Connoropolous before this merges... i dont know if you want this set in global env. is there not a config file to load this into? prefer if theres a .cyrus file or something where you configure this type of thing |
Contributor
|
gotcha… there is a --env-file=path option now I think, to specify that's how you want env vars loaded. I can also tweak the namespace of those env vars a bit 👍 |
- Rename OAUTH_CALLBACK_PORT to CYRUS_OAUTH_CALLBACK_PORT - Rename OAUTH_CALLBACK_BASE_URL to CYRUS_OAUTH_CALLBACK_BASE_URL - Update all references in OAuth URL construction, HTML templates, and console output - Update changelog to document both variables and --env-file option support - Maintains backward compatibility with same default values 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Connoropolous
approved these changes
Jun 25, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
OAUTH_CALLBACK_BASE_URLenvironment variable (defaults to 'http://localhost:3457')Changes
apps/cli/app.tsto useOAUTH_CALLBACK_BASE_URLenvironment variableTest plan
OAUTH_CALLBACK_BASE_URL=https://my-domain.comOAUTH_CALLBACK_BASE_URL=http://my-host:8080Usage
This approach provides maximum flexibility - users can specify the complete base URL (with or without port, HTTP or HTTPS) and the system simply appends
/callbackto it.Closes CEA-122
🤖 Generated with Claude Code