Cassandane failures that happen only on big-endian machines

[jasontibbitts]

I have updated to 3.0.2 and done a new pull of Cassandane from today (rev 6d33978). I've been able to trim down the excluded test list significantly but I'm left with nine failures which happen on a big-endian machine (ppc64) but not on a little-endian (32 or 64 bit intel or ppc64le). Since we've found other endianness-related bugs in the core code I figured that it's worth having a look at these as well. I know Cassandane has tests which might be expected to fail on anything but the head of the tree, but I figured they'd fail uniformly. And since Cassandane is all Perl, I wouldn't really expect it to particularly care about endianness, though I guess if it's doing unpacks it might care.

A complete log is at https://kojipkgs.fedoraproject.org//work/tasks/4794/20104794/build.log but here are some excerpts:

• JMAPCalendars.getcalendareventlist

1) test_getcalendareventlist(Cassandane::Cyrus::JMAPCalendars)
 expected 1, got 2 at Cassandane/Cyrus/JMAPCalendars.pm line 2129.

• JMAPCalendars.getcalendareventupdates

2) test_getcalendareventupdates(Cassandane::Cyrus::JMAPCalendars)
 expected 0, got 1 at /usr/share/perl5/vendor_perl/Test/Unit/Exception.pm line 13.
	Test::Unit::Exception::throw_new(Test::Unit::Failure=HASH(0x10023c0eae8), "-package", "Cassandane::Cyrus::JMAPCalendars", "-file", "Cassandane/Cyrus/JMAPCalendars.pm", "-line", 1922, "-object", ...) called at /usr/share/perl5/vendor_perl/Test/Unit/Assert.pm line 147
	Test::Unit::Assert::assert_equals(Cassandane::Cyrus::JMAPCalendars=HASH(0x1002238c040), JSON::PP::Boolean=SCALAR(0x1001fd63738), JSON::PP::Boolean=SCALAR(0x1001fd63768)) called at Cassandane/Cyrus/JMAPCalendars.pm line 1922
	Cassandane::Cyrus::JMAPCalendars::test_getcalendareventupdates(Cassandane::Cyrus::JMAPCalendars=HASH(0x1002238c040)) called at /usr/share/perl5/vendor_perl/Test/Unit/TestCase.pm line 75

• JMAPCalendars.setcalendarevents_recurrence

3) test_setcalendarevents_recurrence(Cassandane::Cyrus::JMAPCalendars)
 Structures begin differing at:
  $a->{recurrenceRule}{byDay}[0]{nthOfPeriod} = Does not exist
  $b->{recurrenceRule}{byDay}[0]{nthOfPeriod} = '-2'
 at Cassandane/Cyrus/JMAPCalendars.pm line 604.
	Cassandane::Cyrus::JMAPCalendars::assert_normalized_event_equals(Cassandane::Cyrus::JMAPCalendars=HASH(0x10022393e90), HASH(0x10023be7068), HASH(0x10023bb38c0)) called at Cassandane/Cyrus/JMAPCalendars.pm line 1483
	Cassandane::Cyrus::JMAPCalendars::test_setcalendarevents_recurrence(Cassandane::Cyrus::JMAPCalendars=HASH(0x10022393e90)) called at /usr/share/perl5/vendor_perl/Test/Unit/TestCase.pm line 75

• JMAPContacts.getcontactgroupupdates

4) test_getcontactgroupupdates(Cassandane::Cyrus::JMAPContacts)
 '31' and '31' should differ at Cassandane/Cyrus/JMAPContacts.pm line 604.
	Cassandane::Cyrus::JMAPContacts::test_getcontactgroupupdates(Cassandane::Cyrus::JMAPContacts=HASH(0x1002239e788)) called at /usr/share/perl5/vendor_perl/Test/Unit/TestCase.pm line 75

• JMAPContacts.getcontactupdates

5) test_getcontactupdates(Cassandane::Cyrus::JMAPContacts)
 '26' and '26' should differ at Cassandane/Cyrus/JMAPContacts.pm line 206.
	Cassandane::Cyrus::JMAPContacts::test_getcontactupdates(Cassandane::Cyrus::JMAPContacts=HASH(0x1002239e188)) called at /usr/share/perl5/vendor_perl/Test/Unit/TestCase.pm line 75

• JMAPMail.getmailboxupdates

6) test_getmailboxupdates(Cassandane::Cyrus::JMAPMail)
 expected 1, got 0 at /usr/share/perl5/vendor_perl/Test/Unit/Exception.pm line 13.
	Test::Unit::Exception::throw_new(Test::Unit::Failure=HASH(0x10023d43a70), "-package", "Cassandane::Cyrus::JMAPMail", "-file", "Cassandane/Cyrus/JMAPMail.pm", "-line", 943, "-object", ...) called at /usr/share/perl5/vendor_perl/Test/Unit/Assert.pm line 147
	Test::Unit::Assert::assert_equals(Cassandane::Cyrus::JMAPMail=HASH(0x100228905b8), JSON::PP::Boolean=SCALAR(0x1001fd63768), JSON::PP::Boolean=SCALAR(0x1001fd63738)) called at Cassandane/Cyrus/JMAPMail.pm line 943
	Cassandane::Cyrus::JMAPMail::test_getmailboxupdates(Cassandane::Cyrus::JMAPMail=HASH(0x100228905b8)) called at /usr/share/perl5/vendor_perl/Test/Unit/TestCase.pm line 75

• JMAPMail.getmessagelist_window

7) test_getmessagelist_window(Cassandane::Cyrus::JMAPMail)
 Structures begin differing at:
  $a->[0] = 'M8cee21212742eb09c04af7af'
  $b->[0] = Does not exist
 at Cassandane/Cyrus/JMAPMail.pm line 3320.
	Cassandane::Cyrus::JMAPMail::test_getmessagelist_window(Cassandane::Cyrus::JMAPMail=HASH(0x100228984e8)) called at /usr/share/perl5/vendor_perl/Test/Unit/TestCase.pm line 75

• JMAPMail.getmessageupdates

8) test_getmessageupdates(Cassandane::Cyrus::JMAPMail)
 expected 1, got 0 at /usr/share/perl5/vendor_perl/Test/Unit/Exception.pm line 13.
	Test::Unit::Exception::throw_new(Test::Unit::Failure=HASH(0x10023a1b1c8), "-package", "Cassandane::Cyrus::JMAPMail", "-file", "Cassandane/Cyrus/JMAPMail.pm", "-line", 3966, "-object", ...) called at /usr/share/perl5/vendor_perl/Test/Unit/Assert.pm line 147
	Test::Unit::Assert::assert_equals(Cassandane::Cyrus::JMAPMail=HASH(0x100224dbba8), JSON::PP::Boolean=SCALAR(0x1001fd63768), JSON::PP::Boolean=SCALAR(0x1001fd63738)) called at Cassandane/Cyrus/JMAPMail.pm line 3966
	Cassandane::Cyrus::JMAPMail::test_getmessageupdates(Cassandane::Cyrus::JMAPMail=HASH(0x100224dbba8)) called at /usr/share/perl5/vendor_perl/Test/Unit/TestCase.pm line 75

• JMAPMail.getthreadupdates

9) test_getthreadupdates(Cassandane::Cyrus::JMAPMail)
 expected 1, got 0 at /usr/share/perl5/vendor_perl/Test/Unit/Exception.pm line 13.
	Test::Unit::Exception::throw_new(Test::Unit::Failure=HASH(0x10023a3b1e8), "-package", "Cassandane::Cyrus::JMAPMail", "-file", "Cassandane/Cyrus/JMAPMail.pm", "-line", 4368, "-object", ...) called at /usr/share/perl5/vendor_perl/Test/Unit/Assert.pm line 147
	Test::Unit::Assert::assert_equals(Cassandane::Cyrus::JMAPMail=HASH(0x1002288dcb0), JSON::PP::Boolean=SCALAR(0x1001fd63768), JSON::PP::Boolean=SCALAR(0x1001fd63738)) called at Cassandane/Cyrus/JMAPMail.pm line 4368
	Cassandane::Cyrus::JMAPMail::test_getthreadupdates(Cassandane::Cyrus::JMAPMail=HASH(0x1002288dcb0)) called at /usr/share/perl5/vendor_perl/Test/Unit/TestCase.pm line 75

[elliefm]

@rsto, do you have any insight here?

[rsto]

I'm onto a related issue #2042 but so far unsuccessfully.

I have to get a local 32-bit environment running and will fix this.

[jasontibbitts]

Yeah, I have a feeling the endianness issues and the 32-bit issue are all related.

As I've done for @elliefm before, I can provide access to a ppc64 machine with a chroot all set up for reproducing these problems.

[jasontibbitts]

I'm happy to report that with the two patches from #2042, all nine of these test failures appear to be fixed as well on ppc64. I'm pretty sure they will be OK on s390x but our builders for that architecture are so slow that I just skip running Cassandane there. I will do a special build just to check, and if there are still issues then I'll report back.

[rsto]

I guess the builds all went fine? If not, feel free to reopen this issue.

[jasontibbitts]

Yes, everything was fine.