Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add prometheus metrics for httpd #2098

Merged
merged 5 commits into from Jul 27, 2018
Merged

Conversation

elliefm
Copy link
Contributor

@elliefm elliefm commented Aug 15, 2017

This adds two kinds of metrics to httpd:

  • basic connection level stuff (total connections, active connections, ready listeners, shutdown statuses)
  • general method/namespace stuff (introspectively)

I expect at some point we will want to enrich the statistics we gather for some protocols that sit on top of httpd -- I'm thinking particularly of JMAP here. There's no reason that each imap/http_[namespace].c file cannot track its own metrics in addition to the generic ones imap/httpd.c tracks: just set them up and count them appropriately. I'd suggest naming such metrics cyrus_jmap_... or whatever, so they're clearly distinct from cyrus_http_...

In the meantime though, here's the bones. I think this is also a pretty good demo of how to add new metrics to services we're not currently tracking metrics from (such as popd).

Copy link
Contributor

@ksmurchison ksmurchison left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know anything about prometheus, but these patches look sane.

I could certainly see a desire to keep track of certain REPORT types or POST requests depending on the namespace.

@elliefm elliefm assigned elliefm and ajaysusarla and unassigned elliefm Aug 23, 2017
@elliefm elliefm self-assigned this Nov 10, 2017
@elliefm
Copy link
Contributor Author

elliefm commented May 2, 2018

rebased onto current master and fixed conflicts

@elliefm elliefm merged commit 8e3bc17 into cyrusimap:master Jul 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants