Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upadd prometheus metrics for httpd #2098
Merged
Conversation
|
I don't know anything about prometheus, but these patches look sane. I could certainly see a desire to keep track of certain REPORT types or POST requests depending on the namespace. |
|
rebased onto current master and fixed conflicts |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
elliefm commentedAug 15, 2017
This adds two kinds of metrics to httpd:
I expect at some point we will want to enrich the statistics we gather for some protocols that sit on top of httpd -- I'm thinking particularly of JMAP here. There's no reason that each
imap/http_[namespace].cfile cannot track its own metrics in addition to the generic onesimap/httpd.ctracks: just set them up and count them appropriately. I'd suggest naming such metricscyrus_jmap_...or whatever, so they're clearly distinct fromcyrus_http_...In the meantime though, here's the bones. I think this is also a pretty good demo of how to add new metrics to services we're not currently tracking metrics from (such as popd).