Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upprometheus: service labels based on config_ident #2110
Merged
Conversation
2b90a23
to
4c1cea5
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
elliefm commentedAug 22, 2017
•
edited
This PR labels metrics with the ident of the service counting them. For example if your cyrus.conf has both "imap" and "imaps" services, the
cyrus_imap_foometric will be split up intocyrus_imap_foo{service="imap"}andcyrus_imap_foo{service="imaps"}, even though the same binary is used for both services.To avoid reporting metric/service combinations that will never be seen (e.g.
cyrus_lmtp_foo{service="imap"}), this PR:prometheus_init(), instead leaving it as zero; andA consequence of this is that a newly started Cyrus instance will report very few statistics at all, but the report will gradually thicken out as interesting events occur and are counted.