Fix configure ac for autoconf 2.70 #644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
praiskup
force-pushed
the
fix-configure-ac-for-autoconf-2.70
branch
3 times, most recently
from
c249b23
to
d3bcaf6
Compare
|
This should fix #643 |
|
FWIW: Tested locally and it does fix #643, I included these patches in the Fedora Rawhide package. |
|
Any progress on this PR to be merged? |
|
Needs me to finish getting the CLA bot set up and for the author to sign the CLA, for starters. |
|
Feel free to use patches under Public Domain, if that helps. |
|
FWIW, authors do not have a lot of interest in signing CLAs for half-dead projects, I strongly suggest you use an inbound-outbound license instead, and a DCO, to lower barriers to contribution. |
|
Please update your pull request so it has been signed off on in accordance with our DCO. Thanks! |
In the COMMANDS-TO-SET-IT argument, per Autoconf docs: https://www.gnu.org/software/autoconf/manual/autoconf-2.63/html_node/Caching-Results.html Signed-off-by: Pavel Raiskup <praiskup@redhat.com>
Autoconf 2.70+ is more picky about the quotation (even though with
previous versions the arguments should have been quoted, too). When we
don't quote macros inside the AC_CACHE_VAL macro - some of the Autoconf
initialization is wrongly ordered in ./configure script and we keep
seeing bugs like:
./configure: line 2165: ac_fn_c_try_run: command not found
Original report: https://bugzilla.redhat.com/1943013
Signed-off-by: Pavel Raiskup <praiskup@redhat.com>
praiskup
force-pushed
the
fix-configure-ac-for-autoconf-2.70
branch
from
d3bcaf6
to
004869f
Compare
|
Done, ptal. |
The exit function requires to include stdlib otherwise this will fail on new versions of MacOS Signed-off-by: Ignacio Casal Quinteiro <qignacio@amazon.com>
In the COMMANDS-TO-SET-IT argument, per Autoconf docs: https://www.gnu.org/software/autoconf/manual/autoconf-2.63/html_node/Caching-Results.html Signed-off-by: Pavel Raiskup <praiskup@redhat.com>
Autoconf 2.70+ is more picky about the quotation (even though with
previous versions the arguments should have been quoted, too). When we
don't quote macros inside the AC_CACHE_VAL macro - some of the Autoconf
initialization is wrongly ordered in ./configure script and we keep
seeing bugs like:
./configure: line 2165: ac_fn_c_try_run: command not found
Original report: https://bugzilla.redhat.com/1943013
Signed-off-by: Pavel Raiskup <praiskup@redhat.com>
…kup/cyrus-sasl into fix644
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.