We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and
privacy statement. We’ll occasionally send you account related emails.
Already on GitHub?
to your account
The return type of unordered_map erase methods should be iterator not void, like in vector.
C++ reference: http://en.cppreference.com/w/cpp/container/unordered_map/erase
The text was updated successfully, but these errors were encountered:
Thanks. We'd welcome a PR with a test :).
Sorry, something went wrong.
Ok, working on that :)
Created a PR for this #1490
I think it would be good to add more tests for erase method on other data structures.
Also, because unordered_map is from C++11, I don't know if it will compile on all platforms.
I added -std=c++11 to CXXFLAGS
(dev) carlos@macbookair:~/code/cython$ git diff HEAD
diff --git a/runtests.py b/runtests.py
index 0e0abf5..01f44a2 100755
@@ -423,6 +423,7 @@ class build_ext(_build_ext):
compiler_obj = self.compiler
if ext.language == 'c++':
compiler_obj.compiler_so = CCACHE + compiler_obj.compiler_so
if getattr(ext, 'openmp', None) and compiler_obj.compiler_type == 'msvc':
BF: close out cython#1484. Return type of unordered_map erase methods…
… should be iterator not void
BF: close out cython#1484. Return type of unordered_map erase method…
…s should be iterator not void
Fixed in #1933.
No branches or pull requests