-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Return type of unordered_map erase methods should be iterator not void #1484
Comments
Thanks. We'd welcome a PR with a test :). |
Ok, working on that :) |
Created a PR for this #1490 Also, because I added (dev) carlos@macbookair:~/code/cython$ git diff HEAD
diff --git a/runtests.py b/runtests.py
index 0e0abf5..01f44a2 100755
--- a/runtests.py
+++ b/runtests.py
@@ -423,6 +423,7 @@ class build_ext(_build_ext):
compiler_obj = self.compiler
if ext.language == 'c++':
compiler_obj.compiler_so.remove('-Wstrict-prototypes')
+ compiler_obj.compiler_so.append('-std=c++11')
if CCACHE:
compiler_obj.compiler_so = CCACHE + compiler_obj.compiler_so
if getattr(ext, 'openmp', None) and compiler_obj.compiler_type == 'msvc':
(dev) carlos@macbookair:~/code/cython$ |
MichaelWS
added a commit
to MichaelWS/cython
that referenced
this issue
Oct 7, 2017
… should be iterator not void
MichaelWS
added a commit
to MichaelWS/cython
that referenced
this issue
Oct 7, 2017
…s should be iterator not void
This was referenced Oct 11, 2017
Fixed in #1933. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The return type of unordered_map erase methods should be
iterator
notvoid
, like invector
.https://github.com/cython/cython/blob/master/Cython/Includes/libcpp/unordered_map.pxd#L45
C++ reference: http://en.cppreference.com/w/cpp/container/unordered_map/erase
The text was updated successfully, but these errors were encountered: