Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dict.pop() calls not optimized #2047

Closed
pitrou opened this issue Dec 19, 2017 · 1 comment
Closed

dict.pop() calls not optimized #2047

pitrou opened this issue Dec 19, 2017 · 1 comment

Comments

@pitrou
Copy link
Contributor

pitrou commented Dec 19, 2017

dict.pop() could be optimized as calling _PyDict_Pop(), but instead it calls the Python-facing method object.
pitrou added a commit to pitrou/cython that referenced this issue Dec 20, 2017
@pitrou
Fix cython#2047: optimize dict.pop() using _PyDict_Pop()
2282d12
pitrou added a commit to pitrou/cython that referenced this issue Dec 20, 2017
@pitrou
Fix cython#2047: optimize dict.pop() using _PyDict_Pop()
91d56ee
@pitrou
Copy link
Contributor Author

pitrou commented Dec 20, 2017 •
edited

I submitted PR #2049 but there are weird compiler errors there that I can't understand. Help welcome :-)

@scoder scoder closed this as completed in 5c2214f Dec 20, 2017
scoder added a commit that referenced this issue Dec 20, 2017
@scoder
Merge pull request #2049 from pitrou/dict_pop
5f4e51e 
Fix #2047: optimize dict.pop() using _PyDict_Pop()
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@pitrou