Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexpected propagation of Cython's build_ext options #2209

Closed
Kamekameha opened this issue Apr 21, 2018 · 0 comments · Fixed by #3561
Closed

Unexpected propagation of Cython's build_ext options #2209

Kamekameha opened this issue Apr 21, 2018 · 0 comments · Fixed by #3561

Comments

@Kamekameha
Copy link
Contributor

From,

user_options = _build_ext.build_ext.user_options
boolean_options = _build_ext.build_ext.boolean_options
help_options = _build_ext.build_ext.help_options
Cython's build_ext starts using and modifying distutils' options attributes directly instead of making a copy of them.

If using setuptools' setup function (most likely the case) and Cython is installed then setuptools will successfully (and unconditionally) import Cython's build_ext, therefore Cython's modifications to these lists do happen and is, more than anything, confusing whenever using directly or subclassing distutils' build_ext that these options appear out of "nowhere".

@Kamekameha Kamekameha changed the title Unexpected propagation of Cython.Distutils.build_ext's options Unexpected propagation of Cython's build_ext options Apr 21, 2018
scoder pushed a commit that referenced this issue Apr 29, 2020
These are mutable and therefore affect the stdlib build_ext options.

Fixes #2209
@scoder scoder added this to the 3.0 milestone Apr 29, 2020
scoder pushed a commit that referenced this issue May 1, 2020
These are mutable and therefore affect the stdlib build_ext options.

Fixes #2209
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants