Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to parent tp_clear() despite @no_gc_clear #2309

Closed
scoder opened this issue Jun 3, 2018 · 0 comments
Closed

Call to parent tp_clear() despite @no_gc_clear #2309

scoder opened this issue Jun 3, 2018 · 0 comments

Comments

@scoder
Copy link
Contributor

scoder commented Jun 3, 2018

@cython.no_gc_clear
cdef class NoClearParent:
     ...

cdef class Child(NoClearParent):
    ...

This fails to C-compile because the child has a tp_clear() implementation that calls the parent class function, but that is not defined.

I think the right thing to do would be to simply not generate the call to the parent class function in tp_clear() (see ModuleNode.py) if the parent has no_gc_clear set.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant