New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Odd behavior when slicing with None #2508
Comments
Agreed that this should be supported. Probably easy to fix since it really only needs a |
@scoder I want to take this issue. Could you possibly point me in the right direction to get started? |
Sure! First, add tests to Then, the 2-element slicing case is handled in Ask back if things are unclear. |
Hey @maxkrivich - I had started work towards remedying this issue, but haven't worked on it in several days, and am more than willing to pass it off to someone with more free time. If you'd like, please feel free to leverage the handful of failing tests I have on my forked branch at master...cjgibson:2508-slicing-fixes. |
Ah, what a nice suite of tests. That should help a lot in getting this right. I would still split up the doctests with the double/triple nested loops (at least by slice type) to keep things readable. And use |
Hahah, @scoder - that's a realization I came to a little late. Had I started with the fully nested case first, I hope I would have resisted the urge to make the tests so large. I'll make time this weekend to trim down the number of tested cases to the minimal set required to cover the usual troublemakers (empty slice, oversized bounds, etc.) and include the requested verbosity. |
Source code for
slicing.pyx
Steps to reproduce:
The text was updated successfully, but these errors were encountered: