New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stdint compat for windows #2570

Open
jbrockmendel opened this Issue Aug 22, 2018 · 4 comments

Comments

Projects
None yet
4 participants
@jbrockmendel

jbrockmendel commented Aug 22, 2018

I have a few cython modules that currently get integer type definitions from numpy using from numpy cimport int64_t, int32_t. Related to #2569, I would prefer to remove the numpy dependency and just use from libc.stdint cimport int64_t, int32_t. Naturally this works on OSX/Linux but fails on Windows.

pandas has a shim for stdint on Windows: https://github.com/pandas-dev/pandas/blob/master/pandas/_libs/src/headers/stdint.h

Would it make sense for this to be done upstream in cython?

@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Aug 22, 2018

Contributor
Contributor

scoder commented Aug 22, 2018

@gabrieldemarmiesse

This comment has been minimized.

Show comment
Hide comment
@gabrieldemarmiesse

gabrieldemarmiesse Aug 23, 2018

Contributor

We'll finally be able to use intptr_t in the docs' examples!

Contributor

gabrieldemarmiesse commented Aug 23, 2018

We'll finally be able to use intptr_t in the docs' examples!

@Yoshi325

This comment has been minimized.

Show comment
Hide comment
@Yoshi325

Yoshi325 Aug 24, 2018

Contributor

I'm willing to give this a go.

Does this require #2183 ?

Contributor

Yoshi325 commented Aug 24, 2018

I'm willing to give this a go.

Does this require #2183 ?

@scoder

This comment has been minimized.

Show comment
Hide comment
@scoder

scoder Aug 24, 2018

Contributor

I don't think it needs #2183. The C code should still be injected early enough.

Contributor

scoder commented Aug 24, 2018

I don't think it needs #2183. The C code should still be injected early enough.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment